-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): take output.indexFiles setting into account #1770
fix(core): take output.indexFiles setting into account #1770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your response. I have requested one minor correction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a comment for refactoring.
a0d9bc0
to
8f1e335
Compare
Seems like #1780 broke headers: Headers was already added to the fetch call by the property |
I included a fix for this in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Status
READY
Description
Fixes #1769
It appears only split-tags mode checked the
indexFiles
flag, but not anymore!The linked PR below fixed this issue for mock imports for split-tags, but the change is necessary for all modes, both mock imports and regular imports.
Related PRs
List related PRs against other branches:
Todos