Prometheus 3.x support and small fixes #146
Open
+12
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
albundy83
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new prometheus 3.x release, if we don't add a header that contains at least
Content-Type: text/plain; version=0.0.4you have the following error:Error scraping target: non-compliant scrape target sending blank Content-Type and no fallback_scrape_protocol specified for targetSee prometheus issue here.
So I have added this header in entrypoint.sh file.
I have also cleaned a non used value that contains a typo
repliaccount, now simply namedreplicas.I have also removed default value for imagePullSecrets that output error in Kubernetes Event log due to non existing Secret (done already here for example).
Latest small update is about Service, Deployment and ServiceMonitor and their targetPort, port and name.
Now everything is identical.