Clean up node:fs utimes, futimes , and lutimes (#16634)

oven-sh · Jan 23, 2025 · b54f3f3 · b54f3f3
1 parent 8882615
commit b54f3f3
Show file tree

Hide file tree

Showing 16 changed files with 741 additions and 230 deletions.
diff --git a/cmake/targets/BuildBun.cmake b/cmake/targets/BuildBun.cmake
@@ -228,6 +228,7 @@ set(BUN_ZIG_GENERATED_CLASSES_OUTPUTS
   ${CODEGEN_PATH}/ZigGeneratedClasses+DOMIsoSubspaces.h
   ${CODEGEN_PATH}/ZigGeneratedClasses+lazyStructureImpl.h
   ${CODEGEN_PATH}/ZigGeneratedClasses.zig
+  ${CODEGEN_PATH}/ZigGeneratedClasses.lut.txt
 )
 
 register_command(
@@ -406,6 +407,7 @@ set(BUN_OBJECT_LUT_SOURCES
   ${CWD}/src/bun.js/bindings/ProcessBindingConstants.cpp
   ${CWD}/src/bun.js/bindings/ProcessBindingNatives.cpp
   ${CWD}/src/bun.js/modules/NodeModuleModule.cpp
+  ${CODEGEN_PATH}/ZigGeneratedClasses.lut.txt
 )
 
 set(BUN_OBJECT_LUT_OUTPUTS
@@ -416,6 +418,7 @@ set(BUN_OBJECT_LUT_OUTPUTS
   ${CODEGEN_PATH}/ProcessBindingConstants.lut.h
   ${CODEGEN_PATH}/ProcessBindingNatives.lut.h
   ${CODEGEN_PATH}/NodeModuleModule.lut.h
+  ${CODEGEN_PATH}/ZigGeneratedClasses.lut.h
 )
 
 macro(WEBKIT_ADD_SOURCE_DEPENDENCIES _source _deps)
@@ -447,6 +450,8 @@ foreach(i RANGE 0 ${BUN_OBJECT_LUT_SOURCES_MAX_INDEX})
       bun-codegen-lut-${filename}
     COMMENT
       "Generating ${filename}.lut.h"
+    DEPENDS
+      ${BUN_OBJECT_LUT_SOURCE}
     COMMAND
       ${BUN_EXECUTABLE}
         run
@@ -478,6 +483,8 @@ WEBKIT_ADD_SOURCE_DEPENDENCIES(
   ${CODEGEN_PATH}/ZigGlobalObject.lut.h
 )
 
+
+
 WEBKIT_ADD_SOURCE_DEPENDENCIES(
   ${CWD}/src/bun.js/bindings/InternalModuleRegistry.cpp
   ${CODEGEN_PATH}/InternalModuleRegistryConstants.h

diff --git a/src/bun.js/api/Timer.zig b/src/bun.js/api/Timer.zig
@@ -80,7 +80,7 @@ pub const All = struct {
             else
                 timespec{ .nsec = 0, .sec = 0 };
 
-            this.uv_timer.start(wait.ms(), 0, &onUVTimer);
+            this.uv_timer.start(wait.msUnsigned(), 0, &onUVTimer);
 
             if (this.active_timer_count > 0) {
                 this.uv_timer.ref();

diff --git a/src/bun.js/node/node.classes.ts b/src/bun.js/node/node.classes.ts
@@ -244,63 +244,26 @@ export default [
           pure: true,
         },
       },
-      dev: {
-        getter: "dev",
-      },
-      ino: {
-        getter: "ino",
-      },
-      mode: {
-        getter: "mode",
-      },
-      nlink: {
-        getter: "nlink",
-      },
-      uid: {
-        getter: "uid",
-      },
-      gid: {
-        getter: "gid",
-      },
-      rdev: {
-        getter: "rdev",
-      },
-      size: {
-        getter: "size",
-      },
-      blksize: {
-        getter: "blksize",
-      },
-      blocks: {
-        getter: "blocks",
-      },
-      atime: {
-        getter: "atime",
-        cache: true,
-      },
-      mtime: {
-        getter: "mtime",
-        cache: true,
-      },
-      ctime: {
-        getter: "ctime",
-        cache: true,
-      },
-      birthtime: {
-        getter: "birthtime",
-      },
-      atimeMs: {
-        getter: "atimeMs",
-      },
-      mtimeMs: {
-        getter: "mtimeMs",
-      },
-      ctimeMs: {
-        getter: "ctimeMs",
-      },
-      birthtimeMs: {
-        getter: "birthtimeMs",
-      },
+    },
+    own: {
+      dev: "dev",
+      ino: "ino",
+      mode: "mode",
+      nlink: "nlink",
+      uid: "uid",
+      gid: "gid",
+      rdev: "rdev",
+      size: "size",
+      blksize: "blksize",
+      blocks: "blocks",
+      atimeMs: "atimeMs",
+      mtimeMs: "mtimeMs",
+      ctimeMs: "ctimeMs",
+      birthtimeMs: "birthtimeMs",
+      atime: "atime",
+      mtime: "mtime",
+      ctime: "ctime",
+      birthtime: "birthtime",
     },
   }),
   define({
@@ -386,76 +349,30 @@ export default [
           pure: true,
         },
       },
-      dev: {
-        getter: "dev",
-      },
-      ino: {
-        getter: "ino",
-      },
-      mode: {
-        getter: "mode",
-      },
-      nlink: {
-        getter: "nlink",
-      },
-      uid: {
-        getter: "uid",
-      },
-      gid: {
-        getter: "gid",
-      },
-      rdev: {
-        getter: "rdev",
-      },
-      size: {
-        getter: "size",
-      },
-      blksize: {
-        getter: "blksize",
-      },
-      blocks: {
-        getter: "blocks",
-      },
-      atime: {
-        getter: "atime",
-        cache: true,
-      },
-      mtime: {
-        getter: "mtime",
-        cache: true,
-      },
-      ctime: {
-        getter: "ctime",
-        cache: true,
-      },
-      birthtime: {
-        getter: "birthtime",
-        cache: true,
-      },
-      atimeMs: {
-        getter: "atimeMs",
-      },
-      mtimeMs: {
-        getter: "mtimeMs",
-      },
-      ctimeMs: {
-        getter: "ctimeMs",
-      },
-      birthtimeMs: {
-        getter: "birthtimeMs",
-      },
-      atimeNs: {
-        getter: "atimeNs",
-      },
-      mtimeNs: {
-        getter: "mtimeNs",
-      },
-      ctimeNs: {
-        getter: "ctimeNs",
-      },
-      birthtimeNs: {
-        getter: "birthtimeNs",
-      },
+    },
+    own: {
+      atime: "atime",
+      atimeMs: "atimeMs",
+      atimeNs: "atimeNs",
+      birthtime: "birthtime",
+      birthtimeMs: "birthtimeMs",
+      birthtimeNs: "birthtimeNs",
+      blksize: "blksize",
+      blocks: "blocks",
+      ctime: "ctime",
+      ctimeMs: "ctimeMs",
+      ctimeNs: "ctimeNs",
+      dev: "dev",
+      gid: "gid",
+      ino: "ino",
+      mode: "mode",
+      mtime: "mtime",
+      mtimeMs: "mtimeMs",
+      mtimeNs: "mtimeNs",
+      nlink: "nlink",
+      rdev: "rdev",
+      size: "size",
+      uid: "uid",
     },
   }),
   define({
@@ -685,4 +602,3 @@ export default [
     },
   }),
 ];
-