Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): "tarball" and "_attachment" path fix #16630

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dylan-conway
Copy link
Member

@dylan-conway dylan-conway commented Jan 23, 2025

What does this PR do?

bun publish was setting the tarball path for "tarball" and the "_attachments" key to @scope-pkg-1.0.0.tgz instead of @scope/pkg-1.0.0.tgz. This works for npm and verdaccio, but the github package registry expects the unmodified scoped form.

fixes #15245

Also moved publish tests into bun-publish.test.ts.

How did you verify your code works?

Added a test for scoped packages because we were missing one, but this test would pass with the previous version of bun.

@robobun
Copy link

robobun commented Jan 23, 2025

Updated 8:52 PM PT - Jan 22nd, 2025

@dylan-conway, your commit 4b97dcd has 3 failures in #10375:


🧪   try this PR locally:

bunx bun-pr 16630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun publish to GitHub Package Registry fails with 400 Bad Request / no attachments present in packument
2 participants