fix(publish): "tarball"
and "_attachment"
path fix
#16630
+980
−851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
bun publish
was setting the tarball path for"tarball"
and the"_attachments"
key to@scope-pkg-1.0.0.tgz
instead of@scope/pkg-1.0.0.tgz
. This works for npm and verdaccio, but the github package registry expects the unmodified scoped form.fixes #15245
Also moved publish tests into
bun-publish.test.ts
.How did you verify your code works?
Added a test for scoped packages because we were missing one, but this test would pass with the previous version of bun.