-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node/fs): add fs.glob
, fs.globSync
, and fs.promises.glob
#16676
base: main
Are you sure you want to change the base?
Conversation
Updated 9:26 PM PT - Jan 23rd, 2025
❌ @DonIsaac, your commit 4717af9 has 2 failures in
🧪 try this PR locally: bunx bun-pr 16676 |
1925f67
to
74bc41e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good but small comments. does this add any passing node tests?
74bc41e
to
4717af9
Compare
this implementation is too minimal for |
What does this PR do?
Adds basic support for
fs.glob
,fs.globSync
, andfs.promises.glob
.These partial implementations should unblock basic use cases. Upstack PRs will move logic into native code (causing
Bun.Glob
to benefit) and add for support more options.Missing APIs
options.withFileTypes
How did you verify your code works?
bun-debug test test-file-name.test
)@types/node
'snode:fs