Skip to content

Commit

Permalink
chore: remove lingering TODO items
Browse files Browse the repository at this point in the history
These TODO items are no longer relevant.
  • Loading branch information
regisb committed Jan 9, 2025
1 parent c1ed03d commit 9a71891
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 3 additions & 5 deletions tutor/commands/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,9 @@ def importdemocourse(
python ./manage.py cms import ../data "$course_root"
# Re-index courses
# TODO this is no longer compatible with meilisearch indexing. That is, until this PR is merged:
# https://github.com/openedx/edx-platform/pull/35743
# Anyway, it doesn't make much sense to reindex *all* courses after a single one has
# been created. Thus we should # rely on course authors to press the "reindex" button in
# the studio after the course has # been imported.
# We are not doing this anymore, because it doesn't make much sense to reindex *all*
# courses after a single one has been created. Thus we should # rely on course authors to
# press the "reindex" button in the studio after the course has # been imported.
#./manage.py cms reindex_course --all --setup
"""
yield ("cms", template)
Expand Down
2 changes: 0 additions & 2 deletions tutor/plugins/openedx.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ def _mount_edx_platform_python_requirements_compose(
for image_name, regex in hooks.Filters.MOUNTED_DIRECTORIES.iterate():
if re.match(regex, folder_name):
# Bind-mount requirement
# TODO this is a breaking change because we associate runtime bind-mounts to
# "openedx" and no longer to "lms", "cms", etc.
volumes.append((image_name, f"/mnt/{folder_name}"))
return volumes

Expand Down

0 comments on commit 9a71891

Please sign in to comment.