feat: disable obnoxious "imghdr" warning in edx-platform #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This warning was popping up with every manage.py command. E.g:
$ ./manage.py lms shell -c "print(1)"
2025-01-08 08:33:37,921 WARNING 33 [py.warnings] [user None] [ip None] warnings.py:110 - /openedx/venv/lib/python3.11/site-packages/pgpy/constants.py:5: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13 import imghdr
With this change, we explicitely ignore this warning. We also get rid
of warning removal which no longer makes sense in Sumac and Django 4.
In our pylint checks, `--errors-only` was effectively overriding our custom list of warnings. I realised this while editing a file in my IDE and a warning popped up. To resolve this issue, we: - disable everything - enable errors - enable a select list of warnings We also include a new warning, which is unnecessary f-string interpolation.
Following the latest changes in pylint configuration, a number of warnings were being reported.
These TODO items are no longer relevant.
DawoudSheraz
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning was popping up with every manage.py command. E.g:
With this change, we explicitely ignore this warning. We also get rid
of warning removal which no longer makes sense in Sumac and Django 4.
We also fix pylint checking and remove a couple of irrelevant TODO items.