refactor: removed not implemented declarations (TODO functions)

owncloud · Jan 23, 2025 · 9dc49a2 · 9dc49a2
1 parent 57fd55b
commit 9dc49a2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/...dApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt b/...dApp/src/main/java/com/owncloud/android/presentation/files/details/FileDetailsFragment.kt
@@ -585,23 +585,23 @@ class FileDetailsFragment : FileFragment() {
     }
 
     override fun updateViewForSyncInProgress() {
-        TODO("Not yet implemented")
+        // Not yet implemented
     }
 
     override fun updateViewForSyncOff() {
-        TODO("Not yet implemented")
+        // Not yet implemented
     }
 
     override fun onFileMetadataChanged(updatedFile: OCFile?) {
         // Nothing to do here. We are observing the oCFile from database, so it should be refreshed automatically
     }
 
     override fun onFileMetadataChanged() {
-        TODO("Not yet implemented")
+        // Not yet implemented
     }
 
     override fun onFileContentChanged() {
-        TODO("Not yet implemented")
+        // Not yet implemented
     }
 
     companion object {

diff --git a/...p/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListViewModel.kt b/...p/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListViewModel.kt
@@ -67,6 +67,7 @@ import kotlinx.coroutines.flow.StateFlow
 import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.flow.firstOrNull
 import kotlinx.coroutines.flow.flatMapLatest
+import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.stateIn
 import kotlinx.coroutines.flow.update
@@ -368,7 +369,7 @@ class MainFileListViewModel(
             FileListOption.ALL_FILES -> retrieveFlowForAllFiles(currentFolderDisplayed, currentFolderDisplayed.owner)
             FileListOption.SHARED_BY_LINK -> retrieveFlowForShareByLink(currentFolderDisplayed, currentFolderDisplayed.owner)
             FileListOption.AV_OFFLINE -> retrieveFlowForAvailableOffline(currentFolderDisplayed, currentFolderDisplayed.owner)
-            FileListOption.SPACES_LIST -> TODO()
+            FileListOption.SPACES_LIST -> flow {}
         }.toFileListUiState(
             currentFolderDisplayed,
             fileListOption,

diff --git a/owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt b/owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
@@ -1351,8 +1351,8 @@ class FileDisplayActivity : FileActivity(),
                     }
 
                     is SynchronizeFileUseCase.SyncType.UploadEnqueued -> showSnackMessage(getString(R.string.upload_enqueued_msg))
-
-                    null -> TODO()
+                    null -> { // Nothing to do
+                    }
                 }
             }
 

diff --git a/.../java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt b/.../java/com/owncloud/android/data/files/datasources/implementation/OCLocalFileDataSource.kt
@@ -209,7 +209,7 @@ class OCLocalFileDataSource(
     }
 
     override fun saveUploadWorkerUuid(fileId: Long, workerUuid: UUID) {
-        TODO("Not yet implemented")
+        // Not yet implemented
     }
 
     override fun saveDownloadWorkerUuid(fileId: Long, workerUuid: UUID) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -1351,8 +1351,8 @@ class FileDisplayActivity : FileActivity(), @@
                         }
                         is SynchronizeFileUseCase.SyncType.UploadEnqueued -> showSnackMessage(getString(R.string.upload_enqueued_msg))
-                        null -> TODO()
+                        null -> { // Nothing to do
+                        }
                     }
                 }
@@ Expand Down @@