Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Dialog title color issue in Samsung devices #4277

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

jrjithin
Copy link
Contributor

@jrjithin jrjithin commented Dec 30, 2023

Related Issues

App: #3192

  • Added changelog files for the fixed issues in the folder changelog/unreleased. More info here

QA

The issue was reproduced on Samsung F41 and verified after the fix.

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 8, 2024

Thanks for your contribution!! we'll take a look and send you feedback about it

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jrjithin! Thanks a lot for your contribution! Here I left some comments to help improve your PR 🍻

changelog/unreleased/3192 Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/share_public_dialog.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/styles.xml Outdated Show resolved Hide resolved
@JuancaG05
Copy link
Collaborator

Hey @jrjithin! You still have 2 pending comments that you didn't applied (maybe you did it locally and didn't push the commits?). I leave it here opened so that you can commit the solution and we can merge your contribution 👍

@jrjithin
Copy link
Contributor Author

@JuancaG05 Thank you for pointing this out. It's resolved now.

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side! Let's QA this @jesmrec.
Thanks again for your valuable contribution @jrjithin! 🍻

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 18, 2024

Nothing to say :D

@JuancaG05 JuancaG05 merged commit ab0a9d4 into owncloud:master Jan 19, 2024
4 checks passed
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
Alert Dialog title color issue in Samsung devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] White title on white background in AlertDialogs in Samsung devices
3 participants