Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 4.1.1 composes /app/list path wrong when instance is installed in subfolder (/owncloud) #4287

Merged
merged 4 commits into from
Jan 24, 2024
Merged

[BUG] 4.1.1 composes /app/list path wrong when instance is installed in subfolder (/owncloud) #4287

merged 4 commits into from
Jan 24, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jan 18, 2024 •
edited
Loading

Related Issues

App: #4279

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp self-assigned this Jan 18, 2024
@Aitorbp Aitorbp linked an issue Jan 18, 2024 that may be closed by this pull request
[BUG] 4.1.1 composes /app/list path wrong when instance is installed in subfolder (/owncloud) #4279
Closed
@JuancaG05 JuancaG05 self-requested a review January 19, 2024 08:49
JuancaG05
JuancaG05 requested changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I leave some changes requested and doubts @Aitorbp!

changelog/unreleased/4287 Outdated Show resolved Hide resolved
...rc/main/java/com/owncloud/android/lib/resources/appregistry/GetRemoteAppRegistryOperation.kt Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the fix/compose_app_list_path_wrong_when_instance_in_subfolder branch from a355b6a to feefa14 Compare January 22, 2024 08:34
@Aitorbp Aitorbp requested a review from JuancaG05 January 22, 2024 09:40
JuancaG05
JuancaG05 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...rc/main/java/com/owncloud/android/lib/resources/appregistry/GetRemoteAppRegistryOperation.kt Show resolved Hide resolved
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 24, 2024

QA checks

  • URL without subfolder without trailing slash
  • URL without subfolder with trailing slash
  • URL with subfolder without trailing slash
  • URL with subfolder with trailing slash

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 24, 2024

approved on my side

@Aitorbp Aitorbp force-pushed the fix/compose_app_list_path_wrong_when_instance_in_subfolder branch from b323015 to 522d9bb Compare January 24, 2024 14:57
@Aitorbp Aitorbp merged commit a5c8863 into master Jan 24, 2024
5 checks passed
@Aitorbp Aitorbp deleted the fix/compose_app_list_path_wrong_when_instance_in_subfolder branch January 24, 2024 16:50
Aitorbp added a commit that referenced this pull request Feb 5, 2024
@Aitorbp
Merge pull request #4287 from owncloud/fix/compose_app_list_path_wron…
3ea4dda 
…g_when_instance_in_subfolder

[BUG] 4.1.1 composes /app/list path wrong when instance is installed in subfolder (/owncloud)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 4.1.1 composes /app/list path wrong when instance is installed in subfolder (/owncloud)
3 participants
@Aitorbp @jesmrec @JuancaG05