Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE] 4.2.0 #4306

Merged
merged 8 commits into from
Feb 13, 2024
Merged

[RELEASE] 4.2.0 #4306

merged 8 commits into from
Feb 13, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Feb 5, 2024

Related Issues

App: #4254


QA

@Aitorbp Aitorbp self-assigned this Feb 5, 2024
@Aitorbp Aitorbp linked an issue Feb 5, 2024 that may be closed by this pull request
28 tasks
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes suggested here @Aitorbp

owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the release/4.2.0 branch 2 times, most recently from fbc6592 to 033f539 Compare February 6, 2024 07:31
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2024

(1) [FIXED]

  1. Install latest stable version 4.1.1
  2. Enter in Settings > Logging > enable logs
  3. Update to current version

Current: app crashes just after opening
Expected: no crash, migration completed

Seems to be a problem with the date format. This is the stacktrace:

FATAL EXCEPTION: main
                 Process: com.owncloud.android.debug, PID: 22679
                 java.lang.RuntimeException: Unable to create application com.owncloud.android.MainApp: java.text.ParseException: Unparseable date: "2024-02-06"
                 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6717)
                 	at android.app.ActivityThread.access$1300(ActivityThread.java:237)
                 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913)
                 	at android.os.Handler.dispatchMessage(Handler.java:106)
                 	at android.os.Looper.loop(Looper.java:223)
                 	at android.app.ActivityThread.main(ActivityThread.java:7656)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
                 Caused by: java.text.ParseException: Unparseable date: "2024-02-06"
                 	at java.text.DateFormat.parse(DateFormat.java:362)
                 	at com.owncloud.android.lib.common.utils.OCFileLoggingTree.<init>(OCFileLoggingTree.kt:68)
                 	at com.owncloud.android.lib.common.utils.OCFileLoggingTree.<init>(OCFileLoggingTree.kt:37)
                 	at com.owncloud.android.lib.common.utils.LoggingHelper.startLogging(LoggingHelper.kt:38)
                 	at com.owncloud.android.providers.LogsProvider.startLogging(LogsProvider.kt:45)
                 	at com.owncloud.android.MainApp.startLogsIfEnabled(MainApp.kt:239)
                 	at com.owncloud.android.MainApp.onCreate(MainApp.kt:99)
                 	at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1192)
                 	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6712)
                 	at android.app.ActivityThread.access$1300(ActivityThread.java:237) 
                 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1913) 
                 	at android.os.Handler.dispatchMessage(Handler.java:106) 
                 	at android.os.Looper.loop(Looper.java:223) 
                 	at android.app.ActivityThread.main(ActivityThread.java:7656) 
                 	at java.lang.reflect.Method.invoke(Native Method) 
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) 

Pixel2 Android11
Samsung Tab A8 Android 13
65b3bccda

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 7, 2024

(2) [FIXED]

Not a technical one: i realised that our changelog/release notes are not complete. Some contributions from community are missing there:

#4263
#4183
#4177

@Aitorbp Aitorbp force-pushed the release/4.2.0 branch 2 times, most recently from edb27ac to 7984744 Compare February 7, 2024 14:49
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 7, 2024

about (2), added some comments to the newly added entries.

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 7, 2024

(3) [WONT FIX]

a very weird behaviour:

  1. Create a deeplink over any item in oCiS account (not tested with oC10)
  2. Click the link to check that it opens the app and the correct file or folder
  3. Go to device Settings > Apps > ownCloud
  4. Clear cache and storage
  5. Click again on the link of step 2

Current behaviour:

Unknown error. Also, i noticed that the spaces warning ocis_accounts_warning_message is displayed

Pixel2 Android11
Samsung Tab A8 Android 13
f54a7cee2

@Aitorbp Aitorbp force-pushed the release/4.2.0 branch 5 times, most recently from 44a3382 to 15744bb Compare February 8, 2024 09:08
@JuancaG05
Copy link
Collaborator

(3) was due to the malfunction of the "Clear data" option, which put the database in a weird inconsistent state. But this is not a regression, so it was solved temporally by disabling the Clear data button and we'll work on it in a separate issue

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 12, 2024

Release 4.2.0 is approved on my side.

Approved commit: 25de31ec8

Android Studio version: Android Studio Hedgehog | 2023.1.1 Patch 2

Devices:

Pixel2, Android11
Samsung Galaxy Tab A8, Android13

Regression Test: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.2/RegressionTest.md
Autom test execution vs oC 10.13.4: https://reports.cucumber.io/reports/68cb56b4-7f3b-444b-96dd-405c5bb95093
Autom test execution vs oCIS5: https://reports.cucumber.io/reports/5b315360-af4e-460d-ab43-82f0d8905603

Great job, team!!

@jesmrec jesmrec self-requested a review February 13, 2024 15:01
@Aitorbp Aitorbp merged commit aa58dba into master Feb 13, 2024
5 checks passed
@Aitorbp Aitorbp deleted the release/4.2.0 branch February 13, 2024 15:02
@Aitorbp Aitorbp restored the release/4.2.0 branch February 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE] 4.2.0
3 participants