-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Make automatic discovery of the account #4325
Conversation
e38e4db
to
5694725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny changes here and ready to go @Aitorbp
...udApp/src/main/java/com/owncloud/android/presentation/accounts/AccountsManagementActivity.kt
Outdated
Show resolved
Hide resolved
...oudApp/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt
Outdated
Show resolved
Hide resolved
8ee5fed
to
dc84b4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems that the branch is conflicting with the current |
dc84b4b
to
fb92f06
Compare
Feature works fine but is not good-performant. The process to discover is the same as before (so, correct) but the complete discovery in accounts with great amount of folders is pretty slow. Just an example Account with: ~13.000 folders took longer than 3 hours to be completely discovered. As first approach is OK, because the given example is just an extreme one to test the app. But, probably, there are other ways to do this task in a more optimal way like depth infinity (needs server logic as well). Other feature (not a bug): If server connection is lost somehow during the discovery process, this is never completed and there is no way to retry/trigger it because of the removal of the circled arrow icon. Known restriction not to forget. Finally we have a kind of feature-loss. Before, users could sync the account whenever they wanted, now, only posible in first login. That is a known restriction as well. |
Let's move this forward, without forgetting the known restrictions |
…ed REFRESH_FOLDER_RECURSIVELY in discoverRootFolder in AccountDiscoveryWorker
…pe to enhancement in ReleaseNotesViewModel
fb92f06
to
03906fb
Compare
Related Issues
App:#4301
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.3/Discovery.md
Some regards: #4325 (comment)