Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Improvements in "Manage accounts" view #4330

Merged
merged 8 commits into from
Mar 12, 2024
Merged

[FEATURE REQUEST] Improvements in "Manage accounts" view #4330

merged 8 commits into from
Mar 12, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Feb 23, 2024 •
edited by jesmrec
Loading

Related Issues

App: #4148

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

QA checks: #4330 (comment)

Reports:

@Aitorbp Aitorbp self-assigned this Feb 23, 2024
@Aitorbp Aitorbp linked an issue Feb 23, 2024 that may be closed by this pull request
[FEATURE REQUEST] Improvements in "Manage accounts" view #4148
Closed
10 tasks
@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch 2 times, most recently from c3b1c68 to c2e5efe Compare February 26, 2024 14:39
@JuancaG05 JuancaG05 self-requested a review March 5, 2024 15:30
@Aitorbp Aitorbp changed the base branch from master to feature/make_automatic_discovery_account March 5, 2024 15:41
@Aitorbp Aitorbp force-pushed the feature/make_automatic_discovery_account branch from 8ee5fed to dc84b4b Compare March 5, 2024 22:37
@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch from c2e5efe to 3cae523 Compare March 6, 2024 09:37
@Aitorbp Aitorbp force-pushed the feature/make_automatic_discovery_account branch from dc84b4b to fb92f06 Compare March 6, 2024 17:50
@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch from 3cae523 to 8e3f8db Compare March 7, 2024 07:46
JuancaG05
JuancaG05 requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested here @Aitorbp!

changelog/unreleased/4330 Outdated Show resolved Hide resolved
owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
...oudApp/src/main/java/com/owncloud/android/presentation/accounts/AccountsManagementAdapter.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/account_item.xml Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch from d25db84 to 985f95a Compare March 7, 2024 12:16
@Aitorbp Aitorbp requested a review from JuancaG05 March 7, 2024 12:17
@Aitorbp Aitorbp force-pushed the feature/make_automatic_discovery_account branch from fb92f06 to 03906fb Compare March 8, 2024 12:05
Base automatically changed from feature/make_automatic_discovery_account to master March 8, 2024 12:20
@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch from 9396c38 to 8c68a9b Compare March 8, 2024 13:22
JuancaG05
JuancaG05 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 11, 2024 •
edited
Loading

Some QA checks:

  • Manage Accounts view: account name does not overlap icons
  • Manage Accounts view: key icon removed
  • Basic auth: lack of authentication shows option to redirect to login view :X: Text in snackbar is Change account
  • OAuth2: lack of authentication shows option to redirect to login view
  • OIDC : lack of authentication shows option to redirect to login view

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 11, 2024 •
edited
Loading

(1) [FIXED]

this is how it looks like now:

Basic OAuth2 OIDC
Screenshot 2024-03-11 at 10 02 12 Screenshot 2024-03-11 at 10 03 15 Screenshot 2024-03-11 at 10 03 56
  • In Basic's dialog, layout seems to be totally different, since the option to click is below the text. In OAuth2/OIDC is next to the text.
  • In Basic's dialog, the button forwards to the login view but the text is CHANGE ACCOUNT instead of SIGN IN

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 12, 2024

Checked the fix: now basic authentication displays the same message as OAuth2 and OIDC, that's not correct because basic auth does not work with tokens.

please, keep the correct message (like the one in the screenshot above) with the sign in option instead of change account

@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch from 8562a02 to c56cfb2 Compare March 12, 2024 12:30
@Aitorbp Aitorbp force-pushed the feature/improvements_in_manage_accounts_view branch from c56cfb2 to 5cb10a8 Compare March 12, 2024 16:09
@jesmrec
Copy link
Collaborator

jesmrec commented Mar 12, 2024

Checked the fix: now basic authentication displays the same message as OAuth2 and OIDC, that's not correct because basic auth does not work with tokens.

please, keep the correct message (like the one in the screenshot above) with the sign in option instead of change account

This is fixed

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 12, 2024

Approved on my side

@Aitorbp Aitorbp merged commit 45148f3 into master Mar 12, 2024
5 checks passed
@Aitorbp Aitorbp deleted the feature/improvements_in_manage_accounts_view branch March 12, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Improvements in "Manage accounts" view
3 participants
@Aitorbp @jesmrec @JuancaG05