Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHNICAL] Detekt: static code analyzer #4487

Draft
wants to merge 48 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
b1e1592
feat: add detekt setup
jesmrec Oct 2, 2024
b2acc7a
feat: add yml setup to execute in github actions
jesmrec Oct 4, 2024
34bd8fd
feat: update detekt version to 1.23.3, adding new fields and removed …
jesmrec Nov 14, 2024
07c329f
feat: add dependency for detekt-rules-libraries and add available fie…
jesmrec Nov 20, 2024
14e89d2
feat: add dependency for detekt-formatting and add available fields t…
jesmrec Nov 20, 2024
284740b
feat: add new fields in 1.23.3 that were disabled: KDocReferencesNonP…
jesmrec Nov 20, 2024
dda1b8c
fix: set the version line with correct format in toml file
jesmrec Dec 2, 2024
3acc471
feat: detekt.yml file with latest rules changes for the first iteration
jesmrec Dec 4, 2024
4e5a304
fix: remove base line, and use correct version of action for gradle
jesmrec Dec 4, 2024
76cc996
style: make lines wrap automatically when they reach 150 characters i…
JuancaG05 Dec 4, 2024
9ad6268
style: wrap lines more than 150 characters in module `owncloudApp`
JuancaG05 Dec 4, 2024
97e574b
style: wrap lines more than 150 characters in module `owncloudComLibr…
JuancaG05 Dec 4, 2024
038a18d
style: wrap lines more than 150 characters in module `owncloudData`
JuancaG05 Dec 10, 2024
4a6e30f
style: wrap lines more than 150 characters in module `owncloudDomain`
JuancaG05 Dec 10, 2024
8284637
style: wrap lines more than 150 characters in module `owncloudTestUtil`
JuancaG05 Dec 10, 2024
ea4a431
refactor: refactor methods with more than 100 lines
JuancaG05 Dec 11, 2024
4cb5c1a
refactor: fix for KtLint report
JuancaG05 Dec 11, 2024
bc227bd
refactor: remove unused private members
joragua Dec 11, 2024
ab6d404
refactor: remove unused private properties in module `owncloudApp`
joragua Dec 11, 2024
9f1e1f6
refactor: remove unused private properties in module `owncloudComLibr…
joragua Dec 11, 2024
664a32f
refactor: replace when by if for binary conditions in module `ownclou…
joragua Dec 11, 2024
220bf75
refactor: replace when by if for binary conditions in module `ownclou…
joragua Dec 11, 2024
1c4a18e
refactor: replace if/else condition with a null block by let in modul…
joragua Dec 11, 2024
2fdb241
refactor: replace if/else condition with a null block by let in modul…
joragua Dec 11, 2024
18bd162
refactor: fix for KtLint report
joragua Dec 11, 2024
4f681b6
refactor: remove unnecessary spaces between packages and imports
joragua Dec 12, 2024
158dd67
refactor: remove explicit `it` in lambda functions
joragua Dec 12, 2024
fe806ca
refactor: collapse if statements
joragua Dec 12, 2024
6d726d4
refactor: remove unused parameters
joragua Dec 12, 2024
19d1fc5
refactor: rename invalid package declaration
joragua Dec 12, 2024
51e7911
feat: set up to run detekt over all the modules in parallel
jesmrec Dec 17, 2024
f6d3361
refactor: remove unnecessary function and join two if conditions
joragua Jan 8, 2025
c2256a5
style: changed functions with just return to expression body in modul…
JuancaG05 Jan 9, 2025
a18c41c
style: changed functions with just return to expression body in modul…
JuancaG05 Jan 9, 2025
edc8491
style: changed functions with just return to expression body in modul…
JuancaG05 Jan 9, 2025
c979df6
style: changed functions with just return to expression body in modul…
JuancaG05 Jan 10, 2025
be20953
style: added new line at the end of the file
JuancaG05 Jan 10, 2025
4ddd6bc
refactor: renamed member so that it doesn't have the name of its class
JuancaG05 Jan 10, 2025
aed0952
refactor: removed unused property
JuancaG05 Jan 10, 2025
5cbfd2a
refactor: replaced forbidden comments by normal comments
joragua Jan 20, 2025
ee7d99a
refactor: removed wildcard imports and added necessary ones
joragua Jan 20, 2025
5979aa1
style: renamed some variables that were not following naming convention
joragua Jan 20, 2025
aa44bc2
refactor: removed empty secondary constructors
joragua Jan 21, 2025
18062d2
refactor: modified some methods with more than 2 `return`
joragua Jan 22, 2025
f62fb05
feat: disabled ReturnCount codesmell from detekt.yml
joragua Jan 22, 2025
57fd55b
style: changed functions with just return to expression body
joragua Jan 23, 2025
9dc49a2
refactor: removed not implemented declarations (TODO functions)
joragua Jan 23, 2025
95ffa42
style: modified some comments and replaced `flow{}` by `flowOf()`
joragua Jan 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -585,23 +585,23 @@ class FileDetailsFragment : FileFragment() {
}

override fun updateViewForSyncInProgress() {
TODO("Not yet implemented")
// Not yet implemented
}

override fun updateViewForSyncOff() {
TODO("Not yet implemented")
// Not yet implemented
}

override fun onFileMetadataChanged(updatedFile: OCFile?) {
// Nothing to do here. We are observing the oCFile from database, so it should be refreshed automatically
}

override fun onFileMetadataChanged() {
TODO("Not yet implemented")
// Not yet implemented
}

override fun onFileContentChanged() {
TODO("Not yet implemented")
// Not yet implemented
}

companion object {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.combine
import kotlinx.coroutines.flow.firstOrNull
import kotlinx.coroutines.flow.flatMapLatest
import kotlinx.coroutines.flow.flow
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.stateIn
import kotlinx.coroutines.flow.update
Expand Down Expand Up @@ -368,7 +369,7 @@ class MainFileListViewModel(
FileListOption.ALL_FILES -> retrieveFlowForAllFiles(currentFolderDisplayed, currentFolderDisplayed.owner)
FileListOption.SHARED_BY_LINK -> retrieveFlowForShareByLink(currentFolderDisplayed, currentFolderDisplayed.owner)
FileListOption.AV_OFFLINE -> retrieveFlowForAvailableOffline(currentFolderDisplayed, currentFolderDisplayed.owner)
FileListOption.SPACES_LIST -> TODO()
FileListOption.SPACES_LIST -> flow {}
JuancaG05 marked this conversation as resolved.
Show resolved Hide resolved
}.toFileListUiState(
currentFolderDisplayed,
fileListOption,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1351,8 +1351,8 @@ class FileDisplayActivity : FileActivity(),
}

is SynchronizeFileUseCase.SyncType.UploadEnqueued -> showSnackMessage(getString(R.string.upload_enqueued_msg))

null -> TODO()
null -> { // Nothing to do
}
JuancaG05 marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class OCLocalFileDataSource(
}

override fun saveUploadWorkerUuid(fileId: Long, workerUuid: UUID) {
TODO("Not yet implemented")
// Not yet implemented
}

override fun saveDownloadWorkerUuid(fileId: Long, workerUuid: UUID) {
Expand Down
Loading