Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHNICAL] Unit tests for repository classes - Part 3 #4523

Merged
merged 15 commits into from
Dec 13, 2024
Merged

[TECHNICAL] Unit tests for repository classes - Part 3 #4523

merged 15 commits into from
Dec 13, 2024

Conversation

joragua
Copy link
Collaborator

@joragua joragua commented Dec 5, 2024 •
edited
Loading

Related Issues

App: #4234

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Dec 5, 2024
@joragua joragua linked an issue Dec 5, 2024 that may be closed by this pull request
[TECHNICAL] Unit tests for repository classes - Part 3 #4234
Closed
10 tasks
@joragua joragua force-pushed the technical/testing_repositories_classes_3 branch 3 times, most recently from 04a5b4d to 6fc7d03 Compare December 10, 2024 13:23
@joragua joragua marked this pull request as ready for review December 10, 2024 13:23
@joragua joragua requested a review from JuancaG05 December 10, 2024 13:42
JuancaG05
JuancaG05 requested changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here @joragua! Here I leave some comments to improve your code a bit 💯

.../test/java/com/owncloud/android/data/folderbackup/repository/OCFolderBackupRepositoryTest.kt Show resolved Hide resolved
.../test/java/com/owncloud/android/data/folderbackup/repository/OCFolderBackupRepositoryTest.kt Outdated Show resolved Hide resolved
.../test/java/com/owncloud/android/data/folderbackup/repository/OCFolderBackupRepositoryTest.kt Outdated Show resolved Hide resolved
.../test/java/com/owncloud/android/data/folderbackup/repository/OCFolderBackupRepositoryTest.kt Outdated Show resolved Hide resolved
.../test/java/com/owncloud/android/data/folderbackup/repository/OCFolderBackupRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Show resolved Hide resolved
joragua and others added 13 commits December 12, 2024 14:47
@joragua
test: added tests for all methods from OCFolderBackupRepository
3260ed9
@joragua
test: added tests for all methods from OCShareeRepository
7411724
@joragua
test: added test for all methods from OCOAuthRepository
07c0576
@joragua
test: added tests for all methods from OCShareRepository
a0fe7b4
@joragua
test: removed unnecessary types for declarations and renamed some tests
5dacd12
@joragua
test: added tests for all methods from OCServerInfoRepository
7ade617
@joragua
chore: added calens file
e96f860
@joragua
test: refactored some asserts and set correct parameters in some tests
993751a
@joragua
docs: calens changelog updated
826b974
@joragua
refactor: renamed some tests and variables and added necessary comments
97defd3
@joragua
refactor: created some packages to keep the same structure between te…
c8dda30 
…sts and classes
@joragua
refactor: removed unnecessary relaxUnitFun and changed some variables
6ef4703
@joragua
refactor: changed asserts in tests with LiveData objects
ae54452
@joragua joragua force-pushed the technical/testing_repositories_classes_3 branch from d221687 to ae54452 Compare December 12, 2024 13:47
@joragua joragua requested a review from JuancaG05 December 12, 2024 13:50
JuancaG05
JuancaG05 requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments here @joragua!

...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
...a/src/test/java/com/owncloud/android/data/sharing/shares/repository/OCShareRepositoryTest.kt Outdated Show resolved Hide resolved
@joragua joragua force-pushed the technical/testing_repositories_classes_3 branch from a0ea76f to ea9bb6f Compare December 13, 2024 09:21
JuancaG05
JuancaG05 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Approved on my side 🚀

@joragua joragua merged commit e6e9859 into master Dec 13, 2024
7 checks passed
@joragua joragua deleted the technical/testing_repositories_classes_3 branch December 13, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@joragua joragua

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Unit tests for repository classes - Part 3
2 participants
@joragua @JuancaG05