-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Multi-Personal (1st round) #4527
Conversation
590f6e4
to
4357850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @JuancaG05!! Only two comments and it's done 😄
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListAdapter.kt
Outdated
Show resolved
Hide resolved
...mLibrary/src/main/java/com/owncloud/android/lib/resources/spaces/responses/SpacesResponse.kt
Show resolved
Hide resolved
5fb1724
to
cde5496
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ready for QA 🚀 (Don't forget to rebase the branch with master. Just a reminder)
cde5496
to
bbd8a5a
Compare
QA checks:
new path field
Spaces:
Regression:
|
bbd8a5a
to
ca29365
Compare
Depending on the After performing the checks (and related) above, it's approved on my side. A new look to be done in terms of regression testing when the release is in QA-phase. Go ahead. |
…paces non-required
… mock a default quota for multi-personal accounts
…paces of multi-personal accounts
3d25a90
to
219ac94
Compare
Related Issues
App: #4514
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA
#4527 (comment)