Skip to content

Commit

Permalink
adding test for disabling mail notifications for space disabled event
Browse files Browse the repository at this point in the history
  • Loading branch information
@nirajacharya2
nirajacharya2 committed Jan 23, 2025
1 parent f041b6a commit 9a23ed9
Show file tree
Hide file tree
Showing 3 changed files with 157 additions and 5 deletions.
46 changes: 43 additions & 3 deletions tests/acceptance/bootstrap/NotificationContext.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,40 @@ public function filterNotificationsBySubjectAndResource(
return $filteredNotifications;
}

/**
* filter notification according to subject and space
*
* @param string $subject
* @param string $space
* @param ResponseInterface|null $response
*
* @return array
*/
public function filterNotificationsBySubjectAndSpace(
string $subject,
string $space,
?ResponseInterface $response = null
): array {
$filteredNotifications = [];
$response = $response ?? $this->featureContext->getResponse();
$responseObject = $this->featureContext->getJsonDecodedResponseBodyContent($response);
if (!isset($responseObject->ocs->data)) {
Assert::fail("Response doesn't contain notification: " . print_r($responseObject, true));
}

$notifications = $responseObject->ocs->data;
foreach ($notifications as $notification) {
if (isset($notification->subject) && $notification->subject === $subject
&& isset($notification->messageRichParameters->space->name)
&& $notification->messageRichParameters->space->name === $space
) {
$this->notificationIds[] = $notification->notification_id;
$filteredNotifications[] = $notification;
}
}
return $filteredNotifications;
}

/**
* @Then /^user "([^"]*)" should (?:get|have) a notification with subject "([^"]*)" and message:$/
*
Expand Down Expand Up @@ -466,21 +500,27 @@ public function userShouldGetNotificationForResourceWithMessage(
}

/**
* @Then user :user should not have a notification related to resource :resource with subject :subject
* @Then /^user "([^"]*)" should not have a notification related to (resource|space) "([^"]*)" with subject "([^"]*)"$/
*
* @param string $user
* @param string $resourceOrSpace
* @param string $resource
* @param string $subject
*
* @return void
*/
public function userShouldNotHaveANotificationRelatedToResourceWithSubject(
public function userShouldNotHaveANotificationRelatedToResourceOrSpaceWithSubject(
string $user,
string $resourceOrSpace,
string $resource,
string $subject
): void {
$response = $this->listAllNotifications($user);
$filteredResponse = $this->filterNotificationsBySubjectAndResource($subject, $resource, $response);
if ($resourceOrSpace === "space") {
$filteredResponse = $this->filterNotificationsBySubjectAndSpace($subject, $resource, $response);
} else {
$filteredResponse = $this->filterNotificationsBySubjectAndResource($subject, $resource, $response);
}
Assert::assertCount(
0,
$filteredResponse,
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/bootstrap/SettingsContext.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,7 @@ public function getBodyForNotificationSetting(string $user, string $event): arra
)->getBody()->getContents()
));
foreach ($settingsValues->bundles[0]->settings as $settingsValue) {
if ($settingsValue->displayName === $event) {
if ($settingsValue->displayName === $event) {
return [
"value" => [
"account_uuid" => "me",
Expand Down
114 changes: 113 additions & 1 deletion tests/acceptance/features/apiSettings/notificationSetting.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ Feature: Notification Settings


Scenario: disable email notification
Given user "Alice" has uploaded file with content "some data" to "lorem.txt"
When user "Brian" disables email notification using the settings API
Then the HTTP status code should be "201"
And the JSON data of the response should match
Expand Down Expand Up @@ -444,3 +443,116 @@ Feature: Notification Settings
| message |
| Alice Hansen shared insideSpace.txt with you |
But user "Brian" should not have a notification related to resource "insideSpace.txt" with subject "Resource unshared"


Scenario: disable in-app notification for Space disabled event
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
And user "Alice" has sent the following space share invitation:
| space | new-space |
| sharee | Brian |
| shareType | user |
| permissionsRole | Space Viewer |
When user "Brian" disables notification for the following events using the settings API:
| Space disabled | in-app |
Then the HTTP status code should be "201"
And the JSON data of the response should match
"""
{
"type": "object",
"required": ["value"],
"properties": {
"value": {
"type": "object",
"required": ["identifier","value"],
"properties": {
"identifier":{
"type": "object",
"required": ["extension","bundle","setting"],
"properties": {
"extension":{
"const": "ocis-accounts"
},
"bundle":{
"const": "profile"
},
"setting":{
"const": "event-space-disabled-options"
}
}
},
"value":{
"type": "object",
"required": [
"id",
"bundleId",
"settingId",
"accountUuid",
"resource",
"collectionValue"
],
"properties":{
"id":{
"pattern":"%user_id_pattern%"
},
"bundleId":{
"pattern":"%user_id_pattern%"
},
"settingId":{
"pattern":"%user_id_pattern%"
},
"accountUuid":{
"pattern":"%user_id_pattern%"
},
"resource":{
"type": "object",
"required":["type"],
"properties": {
"type":{
"const": "TYPE_USER"
}
}
},
"collectionValue":{
"type": "object",
"required":["values"],
"properties": {
"values":{
"type": "array",
"maxItems": 1,
"minItems": 1,
"uniqueItems": true,
"items": {
"oneOf": [
{
"type": "object",
"required": [
"key",
"boolValue"
],
"properties": {
"key":{
"const": "in-app"
},
"boolValue":{
"const": false
}
}
}
]
}
}
}
}
}
}
}
}
}
}
"""
And user "Alice" has disabled a space "new-space"
When user "Brian" lists all notifications
Then the HTTP status code should be "200"
And there should be "1" notifications
But user "Brian" should not have a notification related to space "new-space" with subject "Space disabled"

0 comments on commit 9a23ed9

Please sign in to comment.