[tests-only][full-ci] add test to disable notification for Removed as space member event
#10905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
prashant-gurung899
force-pushed
the
test/space-unshared-notifications
branch
7 times, most recently
from
b09f941 to
af58441
Compare
prashant-gurung899
requested review from
anon-pradip,
saw-jan,
amrita-shrestha,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
amrita-shrestha
requested changes
Jan 23, 2025
prashant-gurung899
force-pushed
the
test/space-unshared-notifications
branch
from
af58441 to
44df9c0
Compare
Signed-off-by: prashant-gurung899 <[email protected]>
prashant-gurung899
force-pushed
the
test/space-unshared-notifications
branch
from
44df9c0 to
3bf9ab0
Compare
|
| * | ||
| * @param string $user | ||
| * @param string $resource | ||
| * @param string $resourceOrSpace | ||
| * @param string $subject | ||
| * | ||
| * @return void | ||
| */ | ||
| public function userShouldNotHaveANotificationRelatedToResourceWithSubject( |
There was a problem hiding this comment.
Suggested change
| public function userShouldNotHaveANotificationRelatedToResourceWithSubject( | |
| public function userShouldNotHaveANotificationRelatedToResourceOrSpaceWithSubject( |
saw-jan
requested changes
Jan 23, 2025
Comment on lines
+373
to
+376
| && ((isset($notification->messageRichParameters->resource->name) | ||
| && $notification->messageRichParameters->resource->name === $resourceOrSpace) | ||
| || (isset($notification->messageRichParameters->space->name) | ||
| && $notification->messageRichParameters->space->name === $resourceOrSpace)) |
There was a problem hiding this comment.
let's not do this. wait for PR #10895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test to disable notification for
Removed as space memberevent.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: