Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RKYV v8 #76

Closed
wants to merge 14 commits into from
Closed

RKYV v8 #76

wants to merge 14 commits into from

Conversation

barvirm
Copy link

@barvirm barvirm commented Nov 10, 2024 •
edited
Loading

master

  • compilation time after clean: +/- 23s
  • library size: 11MB

rkyv_v8:

  • compilation time after clean: +/- 26s
  • library size: 8.9MB
  • benchmark: 0-15% regression from master in some cases due to iteration over ArchivedTypes.
  • I cannot measure recompilation of oxc-browserlist because cargo clean -p oxc-browserlist cleans all workspace dependencies

@Boshen Boshen self-requested a review November 10, 2024 12:04
@Boshen Boshen self-assigned this Nov 10, 2024
@Boshen
Copy link
Member

Boshen commented Nov 10, 2024

The results aren't promising:

In oxc:

cargo build --release --example transformer

Binary size increased from 4.4M to 5.7M.

@barvirm barvirm closed this by deleting the head repository Dec 1, 2024
@Boshen
Copy link
Member

Boshen commented Dec 2, 2024

Thank you for testing and trying this out @barvirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barvirm @Boshen