Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lexer): assert size of Token in 32-bit WASM #8292

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 6, 2025

Token should be 16 bytes in WASM too. Enable this test on 32-bit platforms.

Copy link
Contributor Author

overlookmotel commented Jan 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review January 6, 2025 13:22
@github-actions github-actions bot added A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 6, 2025
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #8292 will not alter performance

Comparing 01-03-test_lexer_assert_size_of_token_in_32-bit_wasm (16dcdaf) with main (922c514)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 01-03-refactor_lexer_make_handle_byte_a_method_of_lexer_ branch from 4e5df89 to 7659cdc Compare January 6, 2025 17:57
@overlookmotel overlookmotel force-pushed the 01-03-test_lexer_assert_size_of_token_in_32-bit_wasm branch from c6f0d9a to 0e188e8 Compare January 6, 2025 17:57
@overlookmotel overlookmotel force-pushed the 01-03-refactor_lexer_make_handle_byte_a_method_of_lexer_ branch from 7659cdc to 4f7c7c0 Compare January 6, 2025 19:52
@overlookmotel overlookmotel force-pushed the 01-03-test_lexer_assert_size_of_token_in_32-bit_wasm branch from 0e188e8 to 52c8537 Compare January 6, 2025 19:52
@overlookmotel overlookmotel force-pushed the 01-03-refactor_lexer_make_handle_byte_a_method_of_lexer_ branch 2 times, most recently from 1838cb3 to df80307 Compare January 6, 2025 20:08
@overlookmotel overlookmotel force-pushed the 01-03-test_lexer_assert_size_of_token_in_32-bit_wasm branch from 52c8537 to 802b90d Compare January 6, 2025 20:08
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 7, 2025
Copy link

graphite-app bot commented Jan 7, 2025

Merge activity

`Token` should be 16 bytes in WASM too. Enable this test on 32-bit platforms.
@Boshen Boshen force-pushed the 01-03-refactor_lexer_make_handle_byte_a_method_of_lexer_ branch from df80307 to 0344e98 Compare January 7, 2025 06:58
@Boshen Boshen force-pushed the 01-03-test_lexer_assert_size_of_token_in_32-bit_wasm branch from 802b90d to 16dcdaf Compare January 7, 2025 06:59
Base automatically changed from 01-03-refactor_lexer_make_handle_byte_a_method_of_lexer_ to main January 7, 2025 07:03
@graphite-app graphite-app bot merged commit 16dcdaf into main Jan 7, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 01-03-test_lexer_assert_size_of_token_in_32-bit_wasm branch January 7, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-parser Area - Parser C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant