Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): remove glob for windows #8390

Merged
merged 8 commits into from
Jan 10, 2025

Conversation

Sysix
Copy link
Collaborator

@Sysix Sysix commented Jan 9, 2025

The current implementations does not work. Under linux it tells me 0 files, under windows:

> [email protected] lint C:\dev\oxc\editors\vscode
> npx oxlint --config=oxlint.json --tsconfig=tsconfig.json client/*.js

Finished in 5ms on 5 files with 101 rules using 24 threads.
Found 0 warnings and 0 errors.

I do not think this glob is needed. we are using ignore in our Walker, which should already covering the use case.

Copy link

graphite-app bot commented Jan 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 9, 2025
@Sysix Sysix marked this pull request as ready for review January 9, 2025 15:21
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #8390 will not alter performance

Comparing Sysix:refactor-linter-remove-glob (8d4f696) with main (6c7acac)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen merged commit 4e05e66 into oxc-project:main Jan 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants