Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize allocations on pass of offsets to pipeline #727

Merged
merged 2 commits into from
Dec 24, 2024
Merged

optimize allocations on pass of offsets to pipeline #727

merged 2 commits into from
Dec 24, 2024

Conversation

DmitryRomanov
Copy link
Collaborator

@DmitryRomanov DmitryRomanov commented Dec 23, 2024 •
edited
Loading

before

BenchmarkLightJsonReadPar-8            1        3706425482 ns/op         391.54 MB/s    135214464 B/op   4192321 allocs/op

after

BenchmarkLightJsonReadPar-8            1        2704712897 ns/op         536.56 MB/s      226584 B/op       2392 allocs/op

@DmitryRomanov DmitryRomanov changed the title memory optimize pass of offsets to pipeline optimize allocations on pass of offsets to pipeline Dec 23, 2024
@DmitryRomanov DmitryRomanov marked this pull request as ready for review December 23, 2024 12:03
@DmitryRomanov DmitryRomanov force-pushed the optimize-pass-offset branch 3 times, most recently from 3f77a34 to 3b8ac5b Compare December 24, 2024 07:08
vadimalekseev
vadimalekseev approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@vadimalekseev vadimalekseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

In an internal discussion, it was agreed to optimize other allocations within another PR to remove the regression in version v0.32.0

@DmitryRomanov DmitryRomanov merged commit 6a1c63c into master Dec 24, 2024
8 checks passed
@DmitryRomanov DmitryRomanov deleted the optimize-pass-offset branch December 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimalekseev vadimalekseev vadimalekseev approved these changes

@HeadHunter483 HeadHunter483 HeadHunter483 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitryRomanov @HeadHunter483 @vadimalekseev