-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove regexps in join_template plugin #731
Open
goshansmails
wants to merge
24
commits into
master
Choose a base branch
from
730-join-template-fast
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 72.28% 73.70% +1.42%
==========================================
Files 137 145 +8
Lines 13985 15347 +1362
==========================================
+ Hits 10109 11312 +1203
- Misses 3311 3412 +101
- Partials 565 623 +58 ☔ View full report in Codecov by Sentry. |
HeadHunter483
approved these changes
Jan 15, 2025
goshansmails
force-pushed
the
730-join-template-fast
branch
from
January 20, 2025 08:59
7f21c37
to
c1f78d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730
Benchmarks on same input:
goos: darwin
goarch: arm64
panic start with regex - 376828 ns/op
panic start without regex - 2397 ns/op
difference is 157 times
almost all input matches:
panic continue with regexp - 1257014 ns/op
panic continue without regexp - 16440 ns/op
difference is 76 times
all input does not match:
panic continue with regexp - 6450680 ns/op
panic continue without regexp - 46257 ns/op
difference is 139 times