Ef misc sizing fixes #38
Conversation
eric-adstage
force-pushed
the
ef-misc-sizing-fixes
branch
from
4714ec5 to
f8487e4
Compare
|
Ping! Just wanted to make sure you saw this @pablosichert. |
|
Changes look good! Let's come back to this after merging and rebasing on #37. |
eric-adstage
force-pushed
the
ef-misc-sizing-fixes
branch
from
f8487e4 to
f1edb23
Compare
eric-adstage
force-pushed
the
ef-misc-sizing-fixes
branch
from
f1edb23 to
86352e5
Compare
|
@pablosichert With my latest timeout patch commit, the build passes for me locally, but fails on Travis -- do you have any idea what might be going on? It's stalling out at some point, and then the build dies after 10 minutes of inactivity. Also, if you have any insight into why the "should recalculate when resizing the window" test would be timing out for me locally, that would be awesome. If there's some fix for that besides upping the default 2000ms timeout, it might fix the Travis issue too. Not sure if there's some inefficiencies I might have inadvertently introduced with my patches that I'm just not seeing. |
|
Hey @pablosichert - Just wondering if you'd had a chance to look into this PR yet. |
|
@pablosichert @eric-adstage I’d love to see this released. How can I help here? |
|
@iamakulov @pablosichert seems to have gone dark -- not sure what happened! |
Hey @pablosichert - I still can't get the tests passing, but here are the changes I want to make for handling padded containers and letter spacing. Any thoughts?