Upgrade symfony components (6.4) #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.lockPackage changes
Dev Package changes
Settings · Docs · Powered by Private Packagist |
pscheit
force-pushed
the
update-symfony
branch
from
c5d9443 to
c34c8c5
Compare
pscheit
commented
Nov 18, 2024
Comment on lines
-19
to
-30
| private readonly MockHttpClient $httpClient; | ||
| private MockHttpClient $httpClient; | ||
| private Command $command; | ||
|
|
||
| /** @phpstan-ignore-next-line TestCase constructor arguments are not covered by backwards-compatibility guarantee */ | ||
| public function __construct(... $args) | ||
| public function setUp(): void | ||
| { | ||
| parent::__construct(... $args); | ||
| $this->httpClient = $this->createMockedResponseHttpClientUsingDirectory(__DIR__ . '/../res/http'); | ||
| } | ||
|
|
||
| public function setUp(): void | ||
| { |
There was a problem hiding this comment.
no idea what changed so that doesnt validate in phpstan anymore (it is fine in 8.2) but on the other hand I don't see a reason why this property needs to be readonly in the first place
glaubinix
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.