Skip to content

Commit

Permalink
!!!!docs(events): add question for review
Browse files Browse the repository at this point in the history
remove after resolving

Signed-off-by: Matej Focko <[email protected]>
  • Loading branch information
mfocko committed Oct 21, 2024
1 parent 9437ea2 commit aa72a20
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packit_service/worker/events/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ def get_db_project_object(self) -> Optional[AbstractProjectObjectDbType]:
def get_db_project_event(self) -> Optional[ProjectEventModel]:
return None

# [XXX] Cache me up inside, related to the comment right above.
@property
def db_project_object(self) -> Optional[AbstractProjectObjectDbType]:
if not self._db_project_object:
Expand Down Expand Up @@ -500,6 +501,8 @@ def pre_check(self) -> bool:
@abstractmethod
def get_packages_config(self): ...

# [XXX] This seems to be used only by .project property, and also
# in a caching way… not sure why do we need two doing the same thing…
@abstractmethod
def get_project(self) -> GitProject: ...

Expand Down

0 comments on commit aa72a20

Please sign in to comment.