Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the latest release including pre-releases #2255

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Get the latest release including pre-releases #2255

merged 1 commit into from
Nov 22, 2023

Conversation

nforro
Copy link
Member

@nforro nforro commented Nov 21, 2023 •
edited
Loading

For GitHub projects, GitProject.get_latest_release() considers only stable releases. If sync_release failed for a pre-release, the retrieved git ref is incorrect. Fix that.

Fixes packit/specfile#325.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/42a7ef568ab54f228503ec6da2a3129c

✔️ pre-commit SUCCESS in 3m 58s
✔️ packit-service-tests SUCCESS in 3m 51s
❌ packit-service-tests-openshift RETRY_LIMIT in 8m 54s

lbarcziova
lbarcziova reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we rather use the first release from get_releases (that one should list all the releases including the pre-releases)?

@nforro nforro changed the title Extract tag name from issue title if possible Get the latest release including pre-releases Nov 21, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/316ec64221c14494b632c3406753674e

✔️ pre-commit SUCCESS in 1m 58s
❌ packit-service-tests FAILURE in 2m 10s
❌ packit-service-tests-openshift RETRY_LIMIT in 7m 52s

@nforro
Copy link
Member Author

nforro commented Nov 22, 2023

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0d54a4b23d4140ada03b2d825e3f13b7

✔️ pre-commit SUCCESS in 1m 51s
❌ packit-service-tests FAILURE in 2m 10s
❌ packit-service-tests-openshift RETRY_LIMIT in 7m 44s

lbarcziova
lbarcziova approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests are green, thanks!

@nforro
Get the latest release including pre-releases
766094f 
For GitHub projects, GitProject.get_latest_release() considers only
stable releases. If sync_release failed for a pre-release,
the retrieved git ref is incorrect. Fix that.

Signed-off-by: Nikola Forró <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f6b03fc73b034300822d8471ca297c9d

✔️ pre-commit SUCCESS in 1m 59s
✔️ packit-service-tests SUCCESS in 2m 32s
❌ packit-service-tests-openshift RETRY_LIMIT in 7m 35s

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Nov 22, 2023
@nforro nforro merged commit ff6c0f5 into packit:main Nov 22, 2023
@nforro nforro deleted the prerelease branch November 22, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[packit] Propose downstream failed for release 0.25.1rc1
2 participants
@nforro @lbarcziova