Draft: GitLab events / parsing refactoring #2590

mfocko · 2024-10-21T12:44:16Z

TODO:

Write new tests or update the old ones to cover new functionality.
Update doc-strings where appropriate.
Update or write new documentation in packit/packit.dev.
‹fill in›

Fixes

Supersedes #2586 (cause GitHub is a 🫓)

Merge before/after

RELEASE NOTES BEGIN

Packit now supports automatic ordering of ☕ after all checks pass.

RELEASE NOTES END

softwarefactory-project-zuul · 2024-10-21T12:48:31Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/077ab2e634e24b49b0a0ea08e10e73b3

✔️ pre-commit SUCCESS in 2m 16s
❌ packit-service-tests FAILURE in 2m 36s

mfocko · 2024-10-21T12:48:46Z

@majamassarini @lbarcziova WDYT? At the moment it's broken everywhere possible :D it looks like we have also some pretty intrusive mocking in place, so this reshuffle opened the can of worms…

I still haven't made up my mind about the usage of the events, cause they can be imported as

from packit_service.worker.events.github.pr import Synchronize

but at the same time I have a feeling that it won't look very good once it gets mixed up with the other forges, for now I replaced the imports with as ‹original_name›, so that it breaks as least stuff as possible, but going forward it doesn't feel very feasible… it probably needs a better hierarchy 🤔

mfocko · 2024-10-21T13:19:36Z

Tip

I had a feeling something will crawl out, when I make Event an abstract class

packit_service/worker/events/github/installation.py:41: error: Cannot instantiate abstract class "Installation" with abstract attributes "base_project" and "get_packages_config"  [abstract]

softwarefactory-project-zuul · 2024-10-21T13:40:42Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/331373bc4bfa4a8889f7a96b500d9078

✔️ pre-commit SUCCESS in 2m 19s
❌ packit-service-tests FAILURE in 2m 30s

softwarefactory-project-zuul · 2024-10-21T13:51:12Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/623a5c1ac72149c1a93fedc8378005d5

✔️ pre-commit SUCCESS in 2m 15s
❌ packit-service-tests FAILURE in 2m 36s

lbarcziova

the structure looks good to me 🚀

for now I replaced the imports with as ‹original_name›, so that it breaks as least stuff as possible, but going forward it doesn't feel very feasible

agreed it may be a good middle step

softwarefactory-project-zuul · 2024-10-25T12:45:54Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/358a8c97e3b844dfbbd5b91b1c2cb07a

✔️ pre-commit SUCCESS in 2m 12s
❌ packit-service-tests FAILURE in 2m 39s

majamassarini · 2024-10-28T08:19:07Z

@majamassarini @lbarcziova WDYT? At the moment it's broken everywhere possible :D it looks like we have also some pretty intrusive mocking in place, so this reshuffle opened the can of worms…

I still haven't made up my mind about the usage of the events, cause they can be imported as
from packit_service.worker.events.github.pr import Synchronize
but at the same time I have a feeling that it won't look very good once it gets mixed up with the other forges, for now I replaced the imports with as ‹original_name›, so that it breaks as least stuff as possible, but going forward it doesn't feel very feasible… it probably needs a better hierarchy 🤔

Thanks for starting this big refactoring, to me it looks good!
If I understand your concern, I think in future we should avoid import like this

from packit_service.worker.events.github.pr import Synchronize

and use instead the namespaces we have created

from packit_service.worker.events import github, gitlab, pagure
[...]
github.pr.Synchronize
[...]
gitlab.pr.Synchronize

So I think the hierarchy is fine 🤔

mfocko · 2024-10-28T08:23:57Z

Thanks for starting this big refactoring, to me it looks good! If I understand your concern, I think in future we should avoid import like this
from packit_service.worker.events.github.pr import Synchronize
and use instead the namespaces we have created
from packit_service.worker.events import github, gitlab, pagure
[...]
github.pr.Synchronize
[...]
gitlab.pr.Synchronize
So I think the hierarchy is fine 🤔

oh i see, so you really wanna use it like that 😁 I was a bit worried how explicit it will be, but I guess it's better

edit: BTW I managed to break the mypy locally, it crashes :D but passes in Zuul…

softwarefactory-project-zuul · 2024-10-28T10:42:29Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/17e07be2f9194d3eaea6bc9637a09b9c

✔️ pre-commit SUCCESS in 2m 05s
❌ packit-service-tests FAILURE in 7m 11s

softwarefactory-project-zuul · 2024-11-25T12:55:14Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/04c5589a7c9f4ed0ae933af2dde529c4

✔️ pre-commit SUCCESS in 2m 03s
❌ packit-service-tests FAILURE in 2m 55s

softwarefactory-project-zuul · 2024-11-25T13:09:21Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/1f38724f9e244d61a8f44cfbbe69cc7a

✔️ pre-commit SUCCESS in 2m 03s
❌ packit-service-tests FAILURE in 2m 42s

softwarefactory-project-zuul · 2024-11-26T15:56:55Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/69c37946c80b4d35a5abe9e9f506a665

✔️ pre-commit SUCCESS in 2m 10s
❌ packit-service-tests FAILURE in 2m 45s

softwarefactory-project-zuul · 2024-12-03T14:11:09Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ec6e67011feb4321940c6feaf2520d7e

✔️ pre-commit SUCCESS in 2m 08s
❌ packit-service-tests FAILURE in 2m 51s

softwarefactory-project-zuul · 2025-01-06T11:34:51Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/173d9c6880614339a0cc924e491afd17

✔️ pre-commit SUCCESS in 1m 47s
❌ packit-service-tests FAILURE in 1m 52s

lbarcziova

I really like how you broke this up into smaller pieces, this is so much more readable, good job!

lbarcziova · 2025-01-08T09:37:53Z

packit_service/worker/events/event.py

@@ -463,12 +461,18 @@ def get_dict(self, default_dict: Optional[dict] = None) -> dict:

        return d

+    # [XXX] Are these supposed to be abstract methods?


yes, I would say these should be abstract

lbarcziova · 2025-01-08T09:42:10Z

packit_service/worker/events/event.py

        """
+        # [XXX] Is `True` as a default here a good idea?


I don't see that as an issue

lbarcziova · 2025-01-08T09:43:59Z

packit_service/worker/events/github/installation.py

+        self.account_id = account_id
+        self.account_url = account_url
+        self.account_type = account_type
+        # repos within the account/namespace


Suggested change

# repos within the account/namespace

# repos within the account/namespace in the scope of the installation

lbarcziova · 2025-01-08T09:57:50Z

packit_service/worker/events/koji.py

looks to me a good candidate for breaking down as well, but can be done as a followup

softwarefactory-project-zuul · 2025-01-13T14:42:54Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/fb5e6b0e33674f928a344ba2e2df857b

✔️ pre-commit SUCCESS in 1m 45s
❌ packit-service-tests FAILURE in 1m 48s

Signed-off-by: Matej Focko <[email protected]>

remove after resolving Signed-off-by: Matej Focko <[email protected]>

Signed-off-by: Matej Focko <[email protected]>

To be consistent with the naming from other modules. Signed-off-by: Matej Focko <[email protected]>

Signed-off-by: Matej Focko <[email protected]>

softwarefactory-project-zuul · 2025-01-15T12:47:27Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/525c3ea383f7482db976a8ca191e3f80

✔️ pre-commit SUCCESS in 1m 50s
❌ packit-service-tests FAILURE in 2m 03s

mfocko self-assigned this Oct 21, 2024

mfocko requested a review from a team as a code owner October 21, 2024 12:44

mfocko force-pushed the fix/gitlab-dg-events branch from feb7e0e to 9a8f285 Compare October 21, 2024 12:45

lbarcziova reviewed Oct 21, 2024

View reviewed changes

mfocko force-pushed the fix/gitlab-dg-events branch from 97853c1 to 1cd634b Compare October 25, 2024 12:42

mfocko mentioned this pull request Oct 31, 2024

Randomize running of the test suite #2613

Open

4 tasks

mfocko linked an issue Nov 18, 2024 that may be closed by this pull request

Prepare and refactor events/parsers for CentOS Stream dist-git comments #2471

Open

8 tasks

mfocko force-pushed the fix/gitlab-dg-events branch from 7f6c114 to 3fa459b Compare November 25, 2024 12:51

mfocko force-pushed the fix/gitlab-dg-events branch from 3fa459b to f9e813c Compare November 25, 2024 13:06

mfocko force-pushed the fix/gitlab-dg-events branch from f9e813c to fee2a38 Compare November 26, 2024 15:53

mfocko force-pushed the fix/gitlab-dg-events branch from fee2a38 to e115f0c Compare December 3, 2024 14:07

mfocko force-pushed the fix/gitlab-dg-events branch from e115f0c to c0c227d Compare January 6, 2025 11:32

lbarcziova reviewed Jan 8, 2025

View reviewed changes

mfocko added 2 commits January 15, 2025 13:44

fix(events): split up github

280f40f

Signed-off-by: Matej Focko <[email protected]>

fix(events): make event an abstract class

a85378c

Signed-off-by: Matej Focko <[email protected]>

mfocko added 15 commits January 15, 2025 13:44

!!!!docs(events): add question for review

9ed0a5d

remove after resolving Signed-off-by: Matej Focko <[email protected]>

docs(events): convert docstring to google-style

6f9706b

Signed-off-by: Matej Focko <[email protected]>

!!! fixup: one more comment for discussion during review

3dfaf91

Signed-off-by: Matej Focko <[email protected]>

fix(events): rename VM Image build result

d29383d

Signed-off-by: Matej Focko <[email protected]>

fix(events): rename TF results

5bfa501

Signed-off-by: Matej Focko <[email protected]>

fix(events): refactor Pagure events

cf4eec0

Signed-off-by: Matej Focko <[email protected]>

fix(events): refactor OpenScanHub events

c360e37

Signed-off-by: Matej Focko <[email protected]>

fix(events): refactor Anitya events

cf4d64f

Signed-off-by: Matej Focko <[email protected]>

fix(events): refactor GitLab events

5307609

Signed-off-by: Matej Focko <[email protected]>

add an empty line to VM image event

ec96b0e

Signed-off-by: Matej Focko <[email protected]>

add an empty line to TF result event

3b90e0d

Signed-off-by: Matej Focko <[email protected]>

fix(events): rename Copr events

7b5d12d

To be consistent with the naming from other modules. Signed-off-by: Matej Focko <[email protected]>

fix(events): factor out abstract classes

236d866

Signed-off-by: Matej Focko <[email protected]>

fix(events): refactor Koji events

0d53bbc

Signed-off-by: Matej Focko <[email protected]>

fix(events): refactor abstract classes

8346172

Signed-off-by: Matej Focko <[email protected]>

mfocko force-pushed the fix/gitlab-dg-events branch from 8e6af25 to 8346172 Compare January 15, 2025 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Draft: GitLab events / parsing refactoring #2590

Draft: GitLab events / parsing refactoring #2590

mfocko commented Oct 21, 2024

softwarefactory-project-zuul bot commented Oct 21, 2024

mfocko commented Oct 21, 2024

mfocko commented Oct 21, 2024

softwarefactory-project-zuul bot commented Oct 21, 2024

softwarefactory-project-zuul bot commented Oct 21, 2024

lbarcziova left a comment

softwarefactory-project-zuul bot commented Oct 25, 2024

majamassarini commented Oct 28, 2024

mfocko commented Oct 28, 2024 •

edited

Loading

softwarefactory-project-zuul bot commented Oct 28, 2024

softwarefactory-project-zuul bot commented Nov 25, 2024

softwarefactory-project-zuul bot commented Nov 25, 2024

softwarefactory-project-zuul bot commented Nov 26, 2024

softwarefactory-project-zuul bot commented Dec 3, 2024

softwarefactory-project-zuul bot commented Jan 6, 2025

lbarcziova left a comment

lbarcziova Jan 8, 2025

lbarcziova Jan 8, 2025

lbarcziova Jan 8, 2025

lbarcziova Jan 8, 2025

softwarefactory-project-zuul bot commented Jan 13, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

		@@ -463,12 +461,18 @@ def get_dict(self, default_dict: Optional[dict] = None) -> dict:

		return d

		# [XXX] Are these supposed to be abstract methods?

	# repos within the account/namespace
	# repos within the account/namespace in the scope of the installation

Draft: GitLab events / parsing refactoring #2590

Are you sure you want to change the base?

Draft: GitLab events / parsing refactoring #2590

Conversation

mfocko commented Oct 21, 2024

softwarefactory-project-zuul bot commented Oct 21, 2024

mfocko commented Oct 21, 2024

mfocko commented Oct 21, 2024

softwarefactory-project-zuul bot commented Oct 21, 2024

softwarefactory-project-zuul bot commented Oct 21, 2024

lbarcziova left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Oct 25, 2024

majamassarini commented Oct 28, 2024

mfocko commented Oct 28, 2024 • edited Loading

softwarefactory-project-zuul bot commented Oct 28, 2024

softwarefactory-project-zuul bot commented Nov 25, 2024

softwarefactory-project-zuul bot commented Nov 25, 2024

softwarefactory-project-zuul bot commented Nov 26, 2024

softwarefactory-project-zuul bot commented Dec 3, 2024

softwarefactory-project-zuul bot commented Jan 6, 2025

lbarcziova left a comment

Choose a reason for hiding this comment

lbarcziova Jan 8, 2025

Choose a reason for hiding this comment

lbarcziova Jan 8, 2025

Choose a reason for hiding this comment

lbarcziova Jan 8, 2025

Choose a reason for hiding this comment

lbarcziova Jan 8, 2025

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jan 13, 2025

softwarefactory-project-zuul bot commented Jan 15, 2025

mfocko commented Oct 28, 2024 •

edited

Loading