Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifier to tests target overrides created in copr end handler #2661

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Add identifier to tests target overrides created in copr end handler #2661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9403b7a
Add identifier to tests target overrides created in copr end handler
majamassarini Nov 27, 2024
03c0f11
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packit_service/worker/handlers/copr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,12 +479,13 @@ def handle_testing_farm(self):
and self.copr_event.chroot
in self.copr_build_helper.build_targets_for_test_job(job_config)
):
event_dict["tests_targets_override"] = list(
self.copr_build_helper.build_target2test_targets_for_test_job(
event_dict["tests_targets_override"] = [
(target, job_config.identifier or "")
for target in self.copr_build_helper.build_target2test_targets_for_test_job(
self.copr_event.chroot,
job_config,
),
)
)
]
signature(
TaskName.testing_farm.value,
kwargs={
Expand Down
2 changes: 1 addition & 1 deletion packit_service/worker/handlers/mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ def copr_build_helper(self) -> CoprBuildJobHelper:
# when reporting state of SRPM build built in Copr
build_targets_override = (
{
(build.target, build.identifier)
(build.target, build.identifier or "")
for build in CoprBuildTargetModel.get_all_by_build_id(
str(self.copr_event.build_id),
)
Expand Down
Loading