-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link dashboard when reporting Koji and Bodhi errors #2663
Link dashboard when reporting Koji and Bodhi errors #2663
Conversation
Build succeeded. ✔️ pre-commit SUCCESS in 2m 02s |
dcd10cf
to
d6d323c
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 2m 08s |
packit_service/constants.py
Outdated
@@ -46,6 +46,10 @@ | |||
"</tr>" | |||
) | |||
|
|||
MSG_DOWNSTREAM_JOB_ERROR_ROW = ( | |||
"<tr>" "<td><code>{branch}</code></td>" '<td>See <a href="{url}">{url}</a></td>' "</tr>\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"<tr>" "<td><code>{branch}</code></td>" '<td>See <a href="{url}">{url}</a></td>' "</tr>\n" | |
"<tr>" "<td><code>{branch}</code></td>" '<td>See <a href="{url}">{url}</a></td>' "</tr>\n" |
I am a bit puzzled by all this double quotes, it is not the first time I see them, I think they are related with ruff?
Do you know why so many? 🙏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right, I think this was changed after running pre-commit, for now adjusted it manually and will try to have a look into it more
Related to packit#2426 This makes it consistent with behaviour for release syncing.
d6d323c
to
b7dc4a1
Compare
Build succeeded. ✔️ pre-commit SUCCESS in 2m 08s |
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 13s |
0f2e9b2
into
packit:main
Related to #2426
This makes it consistent with behaviour for release syncing.
RELEASE NOTES BEGIN
Packit now includes dashboard links when reporting errors for Koji builds and Bodhi updates.
RELEASE NOTES END