Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link dashboard when reporting Koji and Bodhi errors #2663

Conversation

lbarcziova
Copy link
Member

Related to #2426

This makes it consistent with behaviour for release syncing.

RELEASE NOTES BEGIN

Packit now includes dashboard links when reporting errors for Koji builds and Bodhi updates.

RELEASE NOTES END

@lbarcziova lbarcziova requested a review from a team as a code owner November 28, 2024 06:52
@lbarcziova lbarcziova self-assigned this Nov 28, 2024
Copy link
Contributor

@lbarcziova lbarcziova force-pushed the koji-bodhi-dashboard-report branch from dcd10cf to d6d323c Compare November 28, 2024 08:28
Copy link
Contributor

@@ -46,6 +46,10 @@
"</tr>"
)

MSG_DOWNSTREAM_JOB_ERROR_ROW = (
"<tr>" "<td><code>{branch}</code></td>" '<td>See <a href="{url}">{url}</a></td>' "</tr>\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"<tr>" "<td><code>{branch}</code></td>" '<td>See <a href="{url}">{url}</a></td>' "</tr>\n"
"<tr>" "<td><code>{branch}</code></td>" '<td>See <a href="{url}">{url}</a></td>' "</tr>\n"

I am a bit puzzled by all this double quotes, it is not the first time I see them, I think they are related with ruff?
Do you know why so many? 🙏🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right, I think this was changed after running pre-commit, for now adjusted it manually and will try to have a look into it more

Related to packit#2426

This makes it consistent with behaviour for release syncing.
@lbarcziova lbarcziova force-pushed the koji-bodhi-dashboard-report branch from d6d323c to b7dc4a1 Compare November 28, 2024 13:51
Copy link
Contributor

@lbarcziova lbarcziova added the mergeit When set, zuul wil gate and merge the PR. label Nov 28, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/033999c09ee4426193fb15da8e073f5f

✔️ pre-commit SUCCESS in 2m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 0f2e9b2 into packit:main Nov 28, 2024
4 checks passed
@lbarcziova lbarcziova deleted the koji-bodhi-dashboard-report branch November 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants