-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): test Docker images in CI #430
Conversation
segfaults mentioned above resolved in #432 |
2dbc673
to
070604c
Compare
internal/native/mock_server.go
Outdated
r := C.pactffi_using_plugin(m.pact.handle, cPluginName, cPluginVersion) | ||
InstallSignalHandlers() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to install our signal handlers after starting our plugins. I wondered why we were still getting flakes after I had got it passing consistently first time before, and I went back and looked at my previous changes I'd tested and did a 😅
Maintainer Conveniences
make pact_local
command that skips publishing of pacts, and via settingSKIP_PUBLISH
controls the provider verification test to either run a local or pact broker based verification. The publish code path is still covered by the linux runner. (there is probably a more elegant way of conditionally setting the values rather than a large if / else block