Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC AreaCalculator Examples - Updates #46

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Oct 16, 2023

Updates to the gRPC examples

  • Add additional instructions for execution
  • Update consumer-go test to use pact-go v2 non beta
  • Add provider-go pact test
  • Add Makefile to run/test all gRPC area calculator examples
  • Removes go vendored files from source code

- add provider test in go
  currently expects provider to be started externally
- remove vendor folders from source
- explicity ignore vendor folders in examples
add area-calculator makefile
add verifier cli to makefile
- spin up area provider in go grpc provider test
run through all versions, add additional instructions
@YOU54F
Copy link
Member Author

YOU54F commented Oct 16, 2023

Something else is broken in the CI sausage factory unrelated to this change.

Whilst I have your eyes @rholshausen - It would be ace to do a release of the CSV plugin, as there is now aarch64 linux support but there hasn't been a release with one put out. Not important really, but just to put it in my your mind, if you are releasing anything from here soon

@YOU54F
Copy link
Member Author

YOU54F commented Oct 16, 2023

So just looking at the failures - maybe they are just due to it being from a PR and rights to publish/retrieve pacts.

Failing due to not able to retrieve pacts from broker (perms from PR?)

Failing to publish pacts

well failing to find them

@rholshausen
Copy link
Contributor

PR build can't get access to the token to publish the Pacts. Just ignore that.

@rholshausen rholshausen merged commit 44c8bfd into pact-foundation:main Oct 17, 2023
21 of 26 checks passed
@YOU54F YOU54F deleted the workshops branch July 5, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants