deps: support Rack 2 & 3 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note using pr fix from unmaintained gem waterlink/rack-reverse-proxy#73
YOU54F
force-pushed
the
deps/rack_2_3
branch
from
d6074eb to
c534282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #116
Requires rack-reverse-proxy updates
See waterlink/rack-reverse-proxy#73
currently pointing to that commit hash in gemfile, which isn't ideal and we also don't really want to vendor the gem within the pact-foundation
stops #113 from being merged and users of pact-provider-verifier updating to rack 3.1
Relates to pact-foundation/pact-ruby-cli#43