Fix/sinatra 4 1 x #327
Merged
Fix/sinatra 4 1 x #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sinatra will reject requests if they are missing the appropriate HTTP_HOST header, post 4.1.x
See sinatra/sinatra#2053
This change will add the header into the provider in when replaying provider verifications, only in the case that Sinatra is defined to avoid affecting non Sinatra based apps
If a user specifies a
HOSTheader in their pact file, it will be honoured, overwriting the value set here fromlocalhostto the user specified value.