Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B2BP-1011] Normalize URI in cloudfront-functions #530

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

mamu0
Copy link
Contributor

@mamu0 mamu0 commented Jan 10, 2025

List of Changes

Removed trailing slashes (/) from URIs.

Motivation and Context

This change is required to ensure consistent handling of URIs for a static website hosted behind CloudFront.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 8b82080

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 10, 2025

Jira Pull Request Link

This Pull Request refers to the following Jira issue B2BP-1011

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (2f2d9a6) to head (8b82080).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #530   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          25       25           
  Lines        1588     1588           
  Branches       72       72           
=======================================
  Hits         1557     1557           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamu0 mamu0 marked this pull request as ready for review January 10, 2025 15:57
@mamu0 mamu0 requested a review from a team as a code owner January 10, 2025 15:57
@christian-calabrese christian-calabrese merged commit 7e488e2 into main Jan 13, 2025
9 checks passed
@christian-calabrese christian-calabrese deleted the B2BP-1011-enable-uri-ends-with-slash branch January 13, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants