Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVEX-108] Add optional parameter to PR infra workflow #12

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

Krusty93
Copy link
Contributor

Update infra_plan.yaml workflow template by adding an optional parameter to override the path where execute the code review.

It was previously hardcoded to infra/resources, but that path is not applicable to few repositories such as io-infra. For this reason, this PR adds an optional parameter tf_configuration_path to allow clients to set the path to the desired location

@Krusty93 Krusty93 enabled auto-merge (squash) April 12, 2024 15:12
@Krusty93 Krusty93 requested a review from balanza April 12, 2024 15:12
@gunzip
Copy link
Contributor

gunzip commented Apr 14, 2024

lgtm, just note that some projects use multiple cloud providers, ie. "firma con io" which uses azure and aws https://github.com/pagopa/io-sign/tree/main/aws

@Krusty93
Copy link
Contributor Author

lgtm, just note that some projects use multiple cloud providers, ie. "firma con io" which uses azure and aws pagopa/io-sign@main/aws

Me and @balanza are aware of it and we will do required changes when needed. Probably we only need to authenticate in it

@balanza
Copy link
Contributor

balanza commented Apr 15, 2024

lgtm, just note that some projects use multiple cloud providers, ie. "firma con io" which uses azure and aws pagopa/io-sign@main/aws

Me and @balanza are aware of it and we will do required changes when needed. Probably we only need to authenticate in it

Should we think about a structure like <env>/<csp>/<region>?

Copy link

github-actions bot commented Apr 15, 2024

Terraform Plan ('infra/resources/prod/westeurope') 📖

Terraform Plan
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

@Krusty93
Copy link
Contributor Author

lgtm, just note that some projects use multiple cloud providers, ie. "firma con io" which uses azure and aws pagopa/io-sign@main/aws

Me and @balanza are aware of it and we will do required changes when needed. Probably we only need to authenticate in it

Should we think about a structure like <env>/<csp>/<region>?

I'm not sure since you can have a single TF config with multiple CSPs in it

.github/workflows/infra_plan.yaml Outdated Show resolved Hide resolved
@Krusty93 Krusty93 force-pushed the DEVEX-108--ci-tf-plan-2 branch from 841222e to b4d7d93 Compare April 15, 2024 11:43
@balanza balanza self-requested a review April 15, 2024 13:31
@Krusty93 Krusty93 merged commit ec0c6d8 into main Apr 15, 2024
4 checks passed
@Krusty93 Krusty93 deleted the DEVEX-108--ci-tf-plan-2 branch April 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants