-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVEX-108] Add optional parameter to PR infra workflow #12
Conversation
lgtm, just note that some projects use multiple cloud providers, ie. "firma con io" which uses azure and aws https://github.com/pagopa/io-sign/tree/main/aws |
Me and @balanza are aware of it and we will do required changes when needed. Probably we only need to authenticate in it |
Should we think about a structure like |
Terraform Plan ('infra/resources/prod/westeurope') 📖Terraform PlanNo changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
|
I'm not sure since you can have a single TF config with multiple CSPs in it |
841222e
to
b4d7d93
Compare
Update
infra_plan.yaml
workflow template by adding an optional parameter to override the path where execute the code review.It was previously hardcoded to
infra/resources
, but that path is not applicable to few repositories such asio-infra
. For this reason, this PR adds an optional parametertf_configuration_path
to allow clients to set the path to the desired location