Skip to content

Commit

Permalink
Remove networking variables from azure_app_service_exposed module (#66)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucacavallaro authored Jul 24, 2024
1 parent 1b23cbd commit b314def
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions infra/modules/azure_app_service_exposed/app_service.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ resource "azurerm_linux_web_app" "this" {

https_only = true
public_network_access_enabled = true
virtual_network_subnet_id = var.azurerm_subnet_id

identity {
type = "SystemAssigned"
Expand All @@ -19,7 +18,6 @@ resource "azurerm_linux_web_app" "this" {
vnet_route_all_enabled = true
health_check_path = var.health_check_path
health_check_eviction_time_in_min = 2
ip_restriction_default_action = "Deny"

application_stack {
node_version = var.stack == "node" ? "${var.node_version}-lts" : null
Expand Down
2 changes: 0 additions & 2 deletions infra/modules/azure_app_service_exposed/app_service_slot.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ resource "azurerm_linux_web_app_slot" "this" {

https_only = true
public_network_access_enabled = true
virtual_network_subnet_id = var.azurerm_subnet_id

identity {
type = "SystemAssigned"
Expand All @@ -19,7 +18,6 @@ resource "azurerm_linux_web_app_slot" "this" {
vnet_route_all_enabled = true
health_check_path = var.health_check_path
health_check_eviction_time_in_min = 2
ip_restriction_default_action = "Deny"

application_stack {
node_version = var.stack == "node" ? "${var.node_version}-lts" : null
Expand Down
8 changes: 0 additions & 8 deletions infra/modules/azure_app_service_exposed/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,3 @@ variable "sticky_app_setting_names" {
description = "(Optional) A list of application setting names that are not swapped between slots"
default = []
}

# ------------ NETWORKING ------------ #

variable "azurerm_subnet_id" {
type = string
description = "(Optional) Id of the subnet the Function App uses for outbound connectivity"
default = null
}

0 comments on commit b314def

Please sign in to comment.