fix: get naming convention module from git

[christian-calabrese]

List of changes

Get the naming convention module from git instead of local path

Motivation and context

When we'll download the DevEx terraform modules from the terraform registry, it will break due to the missing "dependency" model azure_naming_convention.
For this reason, it's important to get this dependent module from a remote source (in our case, github or the registry when set up)

Type of changes

• Add new resources
• Update configuration to existing resources
• Remove existing resources

Does this introduce a change to production resources with possible user impact?

• Yes, users may be impacted applying this change
• No

Other information

[changeset-bot]

🦋 Changeset detected

Latest commit: f4d01ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
azure_function_app_exposed	Minor
azure_app_service_exposed	Minor
azure_role_assignments	Minor
azure_postgres_server	Minor
azure_storage_account	Minor
azure_api_management	Minor
azure_cosmos_account	Minor
azure_function_app	Minor
azure_app_service	Minor
azure_event_hub	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gunzip]

can't we publish the naming_convention module first and get it from terraform registry?

[christian-calabrese]

can't we publish the naming_convention module first and get it from terraform registry?

I think the alternatives to download the naming convention module from other modules are:

• from the terraform registry without specifying a tag => I think the script that checks hashes would break at any release and it's probably not a good practice
• from the main of the dx repo => Not very elegant
• from the terraform registry pinning always the last version => I'm not really a fan of what we used to do in the past with the storage account module

[gunzip]

why do you need to pin the latest version? from the terraform registry you can point to a major version and get free updates

[gunzip]

I think the script that checks hashes would break at any release

that's the expected behaviour if you don't update the lock file