[DEVEX-131] New TF module to create an Azure App Service #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunzip
reviewed
May 27, 2024
gunzip
approved these changes
May 27, 2024
Krusty93
deleted the
DEVEX-131-produrre-un-modulo-terraform-che-crea-un-app-service-azure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
A new module to create an Azure App Service.
This module creates:
subnet for the app service
production slot
staging slot
private endpoints
This module DOES NOT use vnet routing rules, but instead uses private endpoints to regulate app service access. Then, access is disabled from outside the vnet (without the vpn).
Naming convention is also forced.
Motivation and context
Actual module is too complex and does not force to use certain patterns like private endpoints
Type of changes
Does this introduce a change to production resources with possible user impact?
Other information