[DEVEX-101] Update @pagopa/eslint-config

[lucacavallaro]

List of changes

1. add code-review.yaml pipeline
2. configure yarn 4
3. add @pagopa/eslint-config workspace that exports an eslint flat configuration

ESlint plugins configured

• @eslint/js - default JS rules from eslint
• typescript-eslint - strict and stylistic rules for TypeScript
• eslint-plugin-vitest - common best practices for vitest
• eslint-plugin-perfectionist - non-blocking, auto-fixable ordering rules (import, classes, objects)
• eslint-plugin-prettier to avoid conflicts with prettier formatting

[BurnedMarshal]

We should consider to extend the ruleset adding some plugin to enforce some concepts:

• eslint-plugin-jsdoc

Some ruleset are not yet released for ESLint 9 like we should keep an eye on it:

• eslint-plugin-functional
• eslint-plugin-sonarjs

[gunzip]

What about having two sets? ie. lite vs nazi (we can settle on "lite" for this pr)

[BurnedMarshal]

What about having two sets? ie. lite vs nazi (we can settle on "lite" for this pr)

I agree on having multiple base rulset, but some principles must be guarantees even in lite configuration.

[gunzip]

I'd like to have only auto-fixable items in lite. Which principles are you referring to @BurnedMarshal ?

[BurnedMarshal]

I'd like to have only auto-fixable items in lite. Which principles are you referring to @BurnedMarshal ?

Have only auto-fixable rules is impossible, because even the raccomended ts-eslint and raccomended eslint rules have rules that don't support autofix or have reported errors on autofix feature.
Some of the principles that I would like to see enforced are:

• functional programming
• immutability (reducing side effects)
• complex functions obtained composing simple functions
• reduce dangerous JS patterns

[gunzip]

I've doubts about enforcing functional programming everywhere. Think about a frontend application or infrastructure layers (sdk) where it's not mandatory, neither strongly suggested, to adopt fp-ts or something alike.

[BurnedMarshal]

I've doubts about enforcing functional programming everywhere. Think about a frontend application or infrastructure layers (sdk) where it's not mandatory, neither strongly suggested, to adopt fp-ts or something alike.

I agree, functional programming enforcing can be enabled on "nazy" ruleset or specific rule with functional paradigm.

[lucacavallaro]

I've doubts about enforcing functional programming everywhere. Think about a frontend application or infrastructure layers (sdk) where it's not mandatory, neither strongly suggested, to adopt fp-ts or something alike.

I agree, functional programming enforcing can be enabled on "nazy" ruleset or specific rule with functional paradigm.

I think that functional programming and immutability should be enforced at project-level, for specific workspace/folders.

With this common rules (that will be used by the whole PagoPA org) we should enforce writing good and modern TypeScript code.

Functional programming is not "nazi", it's just a different paradigm that can be used in some workspaces.

[BurnedMarshal]

I've doubts about enforcing functional programming everywhere. Think about a frontend application or infrastructure layers (sdk) where it's not mandatory, neither strongly suggested, to adopt fp-ts or something alike.

I agree, functional programming enforcing can be enabled on "nazy" ruleset or specific rule with functional paradigm.

I think that functional programming and immutability should be enforced at project-level, for specific workspace/folders.

With this common rules (that will be used by the whole PagoPA org) we should enforce writing good and modern TypeScript code.

Functional programming is not "nazi", it's just a different paradigm that can be used in some workspaces.

The functional paradigm is the suggested way for Azure Functions and App Service template in the dx-typescript monorepo, and will be provided as template. Do you mean that linter rules that enforce functional constraint must be defined inside the dx-typescript? I'll provide a ruleset specific in here anyway:

• recommended
• functional

[gunzip]

do this requires more work?