Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1839] migrated code-review pipeline #100

Merged
merged 17 commits into from
Jun 6, 2024
Merged

[#IOPID-1839] migrated code-review pipeline #100

merged 17 commits into from
Jun 6, 2024

Conversation

arcogabbo
Copy link
Contributor

List of Changes

  • migrated code-review pipeline from azdevops to GitHub Actions

Motivation and Context

solve container issues encountered on azdevops platform

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1839

arcogabbo added 16 commits May 31, 2024 10:25
@arcogabbo
[#IOPID-1839] add missing deps on e2e tests dir
c9ab361
@arcogabbo
[#IOPID-1839] tentative: remove entrypoint clause
f4e9cbd
@arcogabbo
[#IOPID-1839] added main project build before e2e tests
85ea170
@arcogabbo
[#IOPID-1839] enable debug mode for troubleshooting
f7affa2
@arcogabbo
[#IOPID-1839] debug: start only basic scenario with new certificates
a9db4cb 
certificates created locally
@arcogabbo
[#IOPID-1839] debug: edit CIE_URL
4696db6
@arcogabbo
[#IOPID-1839] debug: procede with tests only for basic scenario
cb66cb4
@arcogabbo
[#IOPID-1839] tentative: run with all integrations tests scenarios
718853a
@arcogabbo
[#IOPID-1839] tentative: fix other scenarios
c391190
@arcogabbo
[#IOPID-1839] fix: wrong config for redis-cluster scenario
cd5209b
@arcogabbo
[#IOPID-1839] fix: port number for spid-saml-check container
6c76dee
@arcogabbo
[#IOPID-1839] fix: ping command for redis cluster is not available
1de3ebb
@arcogabbo
[#IOPID-1839] fix: redis-cluster not enabled for specific scenario
e43cfe7
@arcogabbo
[#IOPID-1839] removed unnecessary cast
ff06f5c
@arcogabbo
[#IOPID-1839] exported main project build into action template
c81d894
@arcogabbo
[#IOPID-1839] fix: checkout step is needed
19e6632
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arcogabbo arcogabbo marked this pull request as ready for review June 3, 2024 13:36
gquadrati
gquadrati approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work!

BurnedMarshal
BurnedMarshal approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KUDOS

@arcogabbo arcogabbo merged commit 6255cb1 into master Jun 6, 2024
9 checks passed
@arcogabbo arcogabbo deleted the IOPID-1839--code-review-migration branch June 6, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arcogabbo @BurnedMarshal @gquadrati