Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sonar #234

Merged
merged 3 commits into from
Dec 5, 2023
Merged

fix: fix sonar #234

merged 3 commits into from
Dec 5, 2023

Conversation

Benedetta-fabbri
Copy link
Collaborator

Description

Fix sonar code smell

List of Changes

Motivation and Context

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Benedetta-fabbri Benedetta-fabbri changed the title fix sonar fix: fix sonar Dec 5, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@Benedetta-fabbri Benedetta-fabbri merged commit e900579 into release-dev Dec 5, 2023
8 of 9 checks passed
@Benedetta-fabbri Benedetta-fabbri deleted the sonar-from-release-dev branch December 5, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariopelliccioli dariopelliccioli Awaiting requested review from dariopelliccioli dariopelliccioli is a code owner

@antonioT90 antonioT90 Awaiting requested review from antonioT90 antonioT90 is a code owner

@frtrinca frtrinca Awaiting requested review from frtrinca

@stedelia stedelia Awaiting requested review from stedelia stedelia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benedetta-fabbri @frtrinca