feat: add inputs to k8s apply workflow #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tf-apply.tf workflow
micheledellipaoli-pagopa
requested a review
from micdes-pagopa
as a code owner
micheledellipaoli-pagopa
temporarily deployed
to
dev-tf
GitHub Actions
Inactive
micheledellipaoli-pagopa
temporarily deployed
to
dev-tf
GitHub Actions
Inactive
.github/workflows/k8s-apply.yaml
Outdated
|
|
||
| initChecks: | ||
| runs-on: ubuntu-22.04 | ||
| environment: ${{ inputs.environment }} | ||
| if: ${{ inputs.run_k8s_workflow == true }} |
There was a problem hiding this comment.
I think this job should always run
.github/workflows/k8s-apply.yaml
Outdated
| @@ -113,7 +128,7 @@ jobs: | |||
| delete_runner: | |||
| name: Delete Self-Hosted Runner | |||
| needs: [create_runner, deploy] | |||
| if: ${{ always() }} | |||
| if: ${{ inputs.run_k8s_workflow == true }} | |||
There was a problem hiding this comment.
Suggested change
| if: ${{ inputs.run_k8s_workflow == true }} | |
| if: ${{ always() && inputs.run_k8s_workflow == true }} |
I know this looks strange, but it's a workaround to force this job to run in the case when
run_k8s_workflow == true- the
deploystep fails for some reason
otherwise it would not delete the runners
micdes-pagopa
approved these changes
Jan 7, 2025
micdes-pagopa
deleted the
PIN-5811-automating-deployments-jobs-monitoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.