-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [EUDIW-162] First implementation of github action for deployment #55
base: main
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue EUDIW-162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a GOOGLE_SERVICES_JSON_FILE
in this app, so it can be removed I think. Also, there are still a few thing missing like scripts to bump the version of the app. I suggest having a look at what's been done in io-app. Of course we don't need nightly and canary releases like io-app
. There's room for simplification for example we don't need a third version number because we don't need to send multiple candidate versions, thus we could only use three digits major.minor.fix
. You can also propose a different way to bump the app version if you prefer. Let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we backport the new release workflow instead of the old one? This allows us to start a release directly via github without running the command locally.
There is now a new version that uses workflow_dispatch |
Short description
This pull request introduces a GitHub Action workflow to automatically deploy the application whenever changes are pushed to the main branch. The final purpose of this Github Action should be being triggered manually or by a cron
List of changes proposed in this pull request
How to test
Push something to main and check the Action workflow
Note
This is an attempt to see if it's working or not, since it can't be tested