fix: linter errors

pagopa · Oct 14, 2024 · df7b75f · df7b75f
1 parent 4dec82d
commit df7b75f
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 21 deletions.
diff --git a/utils/pdv.ts b/utils/pdv.ts
@@ -9,7 +9,11 @@ import { RedisClientType } from "redis";
 import { Second } from "@pagopa/ts-commons/lib/units";
 import { PdvTokenizerClient } from "./pdvTokenizerClient";
 import { sha256 } from "./crypto";
-import { PDVIdPrefix, sendSampledRedisError } from "./redis";
+import {
+  PDVIdPrefix,
+  sendSampledRedisCommandError,
+  sendSampledRedisNetworkError
+} from "./redis";
 
 // eslint-disable-next-line @typescript-eslint/consistent-type-definitions
 export type PdvDependencies = {
@@ -64,7 +68,7 @@ const obtainTokenFromPDV: (
     TE.chainFirstW(pdvId =>
       pipe(
         deps.redisClientTask,
-        sendSampledRedisError(deps.appInsightsTelemetryClient),
+        sendSampledRedisNetworkError(deps.appInsightsTelemetryClient),
         TE.chain(redisClient =>
           pipe(
             TE.tryCatch(
@@ -76,15 +80,7 @@ const obtainTokenFromPDV: (
                 ),
               E.toError
             ),
-            TE.mapLeft(error => {
-              deps.appInsightsTelemetryClient.trackEvent({
-                name: "fn-elt.getPdvId.redis.command.error",
-                properties: {
-                  error_message: error.message
-                }
-              });
-              return error;
-            })
+            sendSampledRedisCommandError(deps.appInsightsTelemetryClient)
           )
         ),
         TE.map(_ => void 0),
@@ -110,15 +106,7 @@ export const getPdvId: (
           () => redisClient.get(`${PDVIdPrefix}${fiscalCode}`),
           E.toError
         ),
-        TE.mapLeft(error => {
-          deps.appInsightsTelemetryClient.trackEvent({
-            name: "fn-elt.getPdvId.redis.command.error",
-            properties: {
-              error_message: error.message
-            }
-          });
-          return error;
-        }),
+        sendSampledRedisCommandError(deps.appInsightsTelemetryClient),
         TE.chainEitherKW(NonEmptyString.decode)
       )
     ),

diff --git a/utils/redis.ts b/utils/redis.ts
@@ -131,7 +131,7 @@ export const falsyResponseToErrorAsync = (error: Error) => (
     TE.chain(value => (value ? TE.right(value) : TE.left(error)))
   );
 
-export const sendSampledRedisError = (
+export const sendSampledRedisNetworkError = (
   appInsightsTelemetryClient: TelemetryClient
 ) => (
   redisTask: TE.TaskEither<Error, redis.RedisClientType>
@@ -149,3 +149,21 @@ export const sendSampledRedisError = (
       return err;
     })
   );
+
+export const sendSampledRedisCommandError = (
+  appInsightsTelemetryClient: TelemetryClient
+) => (
+  command: TE.TaskEither<Error, string | null>
+): TE.TaskEither<Error, string | null> =>
+  pipe(
+    command,
+    TE.mapLeft(error => {
+      appInsightsTelemetryClient.trackEvent({
+        name: "fn-elt.getPdvId.redis.command.error",
+        properties: {
+          error_message: error.message
+        }
+      });
+      return error;
+    })
+  );