[#IOPID-2343] Introducing Redis cache for PDV Tokenizer calls #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-2343 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 93.06% 91.37% -1.70%
==========================================
Files 25 31 +6
Lines 548 684 +136
Branches 61 88 +27
==========================================
+ Hits 510 625 +115
- Misses 35 54 +19
- Partials 3 5 +2 ☔ View full report in Codecov by Sentry. |
gquadrati
reviewed
Oct 11, 2024
package.json
Outdated
| @@ -71,6 +71,7 @@ | |||
| "kafkajs": "^1.15.0", | |||
| "lodash": "^4.17.21", | |||
| "node-fetch": "^2.6.0", | |||
| "redis": "~4.5.1", | |||
There was a problem hiding this comment.
I think we can safely use ^4.6.10 like fn-fast-login
There was a problem hiding this comment.
upgraded in ff00dfd
|
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
Introducing Redis cache for PDV Tokenizer calls
How Has This Been Tested?
Unit tests, manual integration tests via docker engine
Screenshots (if appropriate):
Types of changes
Checklist: