-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update PULL_REQUEST_TEMPLATE.md (#1221)
- Loading branch information
Showing
1 changed file
with
13 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,25 @@ | ||
| <!--- Please always add a PR description as if nobody knows anything about the context these changes come from. --> | ||
| <!--- Even if we are all from our internal team, we may not be on the same page. --> | ||
| <!--- Write this PR as you were contributing to a public OSS project, where nobody knows you and you have to earn their trust. --> | ||
| <!--- This will improve our projects in the long run! Thanks. --> | ||
|
|
||
| ### List of changes | ||
|
|
||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ### Motivation and context | ||
| ### Motivation and Context | ||
|
|
||
| <!--- Why is this change required? What problem does it solve? --> | ||
|
|
||
| ### Type of changes | ||
|
|
||
| - [ ] Add new resources | ||
| - [ ] Update configuration to existing resources | ||
| - [ ] Remove existing resources | ||
|
|
||
| ### Env to apply | ||
|
|
||
| - [ ] DEV | ||
| - [ ] UAT | ||
| - [ ] PROD | ||
|
|
||
| ### Does this introduce a change to production resources with possible user impact? | ||
|
|
||
| - [ ] Yes, users may be impacted applying this change | ||
| - [ ] No | ||
| ### Major Changes | ||
|
|
||
| ### Does this introduce an unwanted change on infrastructure? Check terraform plan execution result | ||
| <!--- Describe the major changes introduced by this PR --> | ||
|
|
||
| - [ ] Yes | ||
| - [ ] No | ||
| ### Dependencies | ||
|
|
||
| ### Other information | ||
| <!--- If this PR depends on or is related to other PRs, | ||
| list them here using the GitHub syntax: `depends on #123` --> | ||
|
|
||
| <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> | ||
| ### Testing | ||
|
|
||
| --- | ||
| <!--- Describe the testing steps you have performed --> | ||
| <!--- and/or if this PR is already (partially) applied and why --> | ||
|
|
||
| ### If PR is partially applied, why? (reserved to mantainers) | ||
| ### Documentation | ||
|
|
||
| <!--- Describe the blocking cause --> | ||
| <!--- Are there any updates to the documentation? --> | ||
|
|
||
| ### How to apply | ||
| ### Other Considerations | ||
|
|
||
| After PR is approved | ||
| 1. run deploy pipeline from Azure DevOps [io-platform-iac-projects](https://dev.azure.com/pagopaspa/io-platform-iac-projects/_build?view=folders) | ||
| 2. select PR branch | ||
| 3. wait for approval | ||
| <!--- Any additional context, such as breaking changes, security concerns, etc. --> |