Skip to content

Commit

Permalink
Remove useless sku_tier variables
Browse files Browse the repository at this point in the history
  • Loading branch information
BurnedMarshal committed Oct 8, 2024
1 parent 58cac5d commit a823164
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 26 deletions.
1 change: 0 additions & 1 deletion src/domains/citizen-auth-app/09_function_profile.tf
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ module "function_profile" {

app_service_plan_info = {
kind = var.function_profile_kind
sku_tier = var.function_profile_sku_tier
sku_size = var.function_profile_sku_size
maximum_elastic_worker_count = 0
worker_count = null
Expand Down
1 change: 0 additions & 1 deletion src/domains/citizen-auth-app/09_function_profile_async.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "function_profile_async" {

app_service_plan_info = {
kind = var.function_profile_async_kind
sku_tier = var.function_profile_async_sku_tier
sku_size = var.function_profile_async_sku_size
maximum_elastic_worker_count = 0
worker_count = null
Expand Down
18 changes: 0 additions & 18 deletions src/domains/citizen-auth-app/99_variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,6 @@ variable "function_fastlogin_kind" {
default = null
}

variable "function_fastlogin_sku_tier" {
type = string
description = "App service plan sku tier"
default = null
}

variable "function_fastlogin_sku_size" {
type = string
description = "App service plan sku size"
Expand Down Expand Up @@ -276,12 +270,6 @@ variable "function_profile_kind" {
default = null
}

variable "function_profile_sku_tier" {
type = string
description = "App service plan sku tier"
default = null
}

variable "function_profile_sku_size" {
type = string
description = "App service plan sku size"
Expand All @@ -301,12 +289,6 @@ variable "function_profile_async_kind" {
default = null
}

variable "function_profile_async_sku_tier" {
type = string
description = "App service plan sku tier"
default = null
}

variable "function_profile_async_sku_size" {
type = string
description = "App service plan sku size"
Expand Down
3 changes: 0 additions & 3 deletions src/domains/citizen-auth-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@
| <a name="input_function_fastlogin_autoscale_minimum"></a> [function\_fastlogin\_autoscale\_minimum](#input\_function\_fastlogin\_autoscale\_minimum) | The minimum number of instances for this resource. | `number` | `1` | no |
| <a name="input_function_fastlogin_kind"></a> [function\_fastlogin\_kind](#input\_function\_fastlogin\_kind) | App service plan kind | `string` | `null` | no |
| <a name="input_function_fastlogin_sku_size"></a> [function\_fastlogin\_sku\_size](#input\_function\_fastlogin\_sku\_size) | App service plan sku size | `string` | `null` | no |
| <a name="input_function_fastlogin_sku_tier"></a> [function\_fastlogin\_sku\_tier](#input\_function\_fastlogin\_sku\_tier) | App service plan sku tier | `string` | `null` | no |
| <a name="input_function_lollipop_autoscale_default"></a> [function\_lollipop\_autoscale\_default](#input\_function\_lollipop\_autoscale\_default) | The number of instances that are available for scaling if metrics are not available for evaluation. | `number` | `3` | no |
| <a name="input_function_lollipop_autoscale_maximum"></a> [function\_lollipop\_autoscale\_maximum](#input\_function\_lollipop\_autoscale\_maximum) | The maximum number of instances for this resource. | `number` | `10` | no |
| <a name="input_function_lollipop_autoscale_minimum"></a> [function\_lollipop\_autoscale\_minimum](#input\_function\_lollipop\_autoscale\_minimum) | The minimum number of instances for this resource. | `number` | `3` | no |
Expand All @@ -197,11 +196,9 @@
| <a name="input_function_profile_async_autoscale_minimum"></a> [function\_profile\_async\_autoscale\_minimum](#input\_function\_profile\_async\_autoscale\_minimum) | The minimum number of instances for this resource. | `number` | `1` | no |
| <a name="input_function_profile_async_kind"></a> [function\_profile\_async\_kind](#input\_function\_profile\_async\_kind) | App service plan kind | `string` | `null` | no |
| <a name="input_function_profile_async_sku_size"></a> [function\_profile\_async\_sku\_size](#input\_function\_profile\_async\_sku\_size) | App service plan sku size | `string` | `null` | no |
| <a name="input_function_profile_async_sku_tier"></a> [function\_profile\_async\_sku\_tier](#input\_function\_profile\_async\_sku\_tier) | App service plan sku tier | `string` | `null` | no |
| <a name="input_function_profile_count"></a> [function\_profile\_count](#input\_function\_profile\_count) | ############################### Function Profile ############################### | `number` | `2` | no |
| <a name="input_function_profile_kind"></a> [function\_profile\_kind](#input\_function\_profile\_kind) | App service plan kind | `string` | `null` | no |
| <a name="input_function_profile_sku_size"></a> [function\_profile\_sku\_size](#input\_function\_profile\_sku\_size) | App service plan sku size | `string` | `null` | no |
| <a name="input_function_profile_sku_tier"></a> [function\_profile\_sku\_tier](#input\_function\_profile\_sku\_tier) | App service plan sku tier | `string` | `null` | no |
| <a name="input_ingress_load_balancer_ip"></a> [ingress\_load\_balancer\_ip](#input\_ingress\_load\_balancer\_ip) | n/a | `string` | n/a | yes |
| <a name="input_instance"></a> [instance](#input\_instance) | One of beta, prod01, prod02 | `string` | n/a | yes |
| <a name="input_k8s_kube_config_path_prefix"></a> [k8s\_kube\_config\_path\_prefix](#input\_k8s\_kube\_config\_path\_prefix) | n/a | `string` | `"~/.kube"` | no |
Expand Down
3 changes: 0 additions & 3 deletions src/domains/citizen-auth-app/env/weu-prod01/terraform.tfvars
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ ingress_load_balancer_ip = "10.11.0.254"
cidr_subnet_fnlollipop = ["10.0.17.0/26"]
cidr_subnet_fnlollipop_itn = ["10.20.6.0/26"]
function_lollipop_kind = "Linux"
function_lollipop_sku_tier = "PremiumV3"
function_lollipop_sku_size = "P2mv3"
function_lollipop_autoscale_minimum = 3
function_lollipop_autoscale_maximum = 20
Expand All @@ -65,13 +64,11 @@ function_fastlogin_autoscale_default = 10
# Functions app profile (located in Italy North)
cidr_subnet_profile_itn = ["10.20.6.64/26", "10.20.6.128/26"]
function_profile_kind = "Linux"
function_profile_sku_tier = "PremiumV3"
function_profile_sku_size = "P2mv3"

# Functions app profile async (located in Italy North)
cidr_subnet_profile_async_itn = ["10.20.6.192/26"]
function_profile_async_kind = "Linux"
function_profile_async_sku_tier = "PremiumV3"
function_profile_async_sku_size = "P1v3"
function_profile_async_autoscale_minimum = 3 # 3 instance to achieve redundancy and failover
function_profile_async_autoscale_maximum = 30
Expand Down

0 comments on commit a823164

Please sign in to comment.