[EC-318] Allowed GitHub Runner subnet for io-subscription-migration and io-developer-portal-service-data #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform Plan ('src/domains/selfcare/prod/westeurope') 📖Terraform Planmodule.app_services.data.azurerm_linux_function_app.itn_webapp_functions_app: Still reading... [10s elapsed]
module.app_services.data.azurerm_linux_function_app.itn_webapp_functions_app: Still reading... [20s elapsed]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# module.app_services.module.function_devportalservicedata.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-selfcare-be-rg/providers/Microsoft.Web/sites/io-p-devportalsrvdata-fn"
name = "io-p-devportalsrvdata-fn"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Enti & Servizi"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/selfcare/prod/westeurope"
}
# (28 unchanged attributes hidden)
~ site_config {
~ health_check_eviction_time_in_min = 0 -> 10
# (24 unchanged attributes hidden)
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-selfcare-be-common-snet" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
- ip_address = "51.144.56.96/28" -> null
name = "rule"
+ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-selfcare-be-common-snet"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.112/28" -> "51.144.56.96/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.128/28" -> "51.144.56.112/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.144/28" -> "51.144.56.128/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.160/28" -> "51.144.56.144/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.176/28" -> "51.144.56.160/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
+ ip_address = "51.144.56.176/28"
name = "rule"
- virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet" -> null
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# (1 unchanged block hidden)
}
# module.app_services.module.function_devportalservicedata_staging_slot.azurerm_linux_function_app_slot.this will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-selfcare-be-rg/providers/Microsoft.Web/sites/io-p-devportalsrvdata-fn/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Enti & Servizi"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/selfcare/prod/westeurope"
}
# (24 unchanged attributes hidden)
~ site_config {
~ health_check_eviction_time_in_min = 0 -> 10
# (24 unchanged attributes hidden)
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/azure-devops" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/azure-devops"
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
}
# module.app_services.module.function_subscriptionmigrations.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-selfcare-be-rg/providers/Microsoft.Web/sites/io-p-subsmigrations-fn"
name = "io-p-subsmigrations-fn"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Enti & Servizi"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/selfcare/prod/westeurope"
}
# (28 unchanged attributes hidden)
~ site_config {
# (25 unchanged attributes hidden)
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-selfcare-be-common-snet" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-svc-bo-app-snet-01" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-selfcare-be-common-snet"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
- ip_address = "51.144.56.96/28" -> null
name = "rule"
+ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/virtualNetworks/io-p-itn-common-vnet-01/subnets/io-p-itn-svc-bo-app-snet-01"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.112/28" -> "51.144.56.96/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.128/28" -> "51.144.56.112/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.144/28" -> "51.144.56.128/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.160/28" -> "51.144.56.144/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
~ ip_address = "51.144.56.176/28" -> "51.144.56.160/28"
name = "rule"
# (3 unchanged attributes hidden)
}
~ ip_restriction {
+ ip_address = "51.144.56.176/28"
~ name = "io-p-github-runner-snet" -> "rule"
- virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet" -> null
# (3 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# (1 unchanged block hidden)
}
# module.app_services.module.function_subscriptionmigrations_staging_slot.azurerm_linux_function_app_slot.this will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-selfcare-be-rg/providers/Microsoft.Web/sites/io-p-subsmigrations-fn/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Enti & Servizi"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/domains/selfcare/prod/westeurope"
}
# (24 unchanged attributes hidden)
~ site_config {
# (25 unchanged attributes hidden)
~ ip_restriction {
name = "rule"
~ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/azure-devops" -> "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/io-p-github-runner-snet"
# (3 unchanged attributes hidden)
}
+ ip_restriction {
+ action = "Allow"
+ name = "rule"
+ priority = 65000
+ virtual_network_subnet_id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-common/providers/Microsoft.Network/virtualNetworks/io-p-vnet-common/subnets/azure-devops"
}
# (1 unchanged block hidden)
}
}
Plan: 0 to add, 4 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
|
christian-calabrese
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Added runner subnet as allowed for functions
io-subscription-migrationio-developer-portal-service-dataMotivation and context
The functions need a selfhosted runner.
Type of changes
Env to apply
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)
How to apply
After PR is approved