Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trial System environment variables #1180

Closed
wants to merge 2 commits into from

Conversation

kin0992
Copy link
Contributor

@kin0992 kin0992 commented Sep 24, 2024

List of changes

  • Remove the TRIAL_SYSTEM_APIM_BASE_PATH environment variable
  • Update value of TRIAL_SYSTEM_APIM_URL environment variable

Motivation and context

The variable is unused.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@kin0992 kin0992 requested a review from a team as a code owner September 24, 2024 10:09
@github-actions github-actions bot added the core label Sep 24, 2024
@kin0992 kin0992 requested a review from AleDore September 24, 2024 12:51
@kin0992 kin0992 force-pushed the fixes/remove-unused-env-variable branch from 5820b50 to 7946488 Compare September 25, 2024 07:42
@kin0992 kin0992 mentioned this pull request Sep 25, 2024
10 tasks
@kin0992 kin0992 changed the title Remove TRIAL_SYSTEM_APIM_BASE_PATH env variable Update Trial System environment variables Sep 25, 2024
@kin0992 kin0992 force-pushed the fixes/remove-unused-env-variable branch from bbe92de to d3a9c2f Compare September 25, 2024 15:24
Copy link

@kin0992 kin0992 deleted the fixes/remove-unused-env-variable branch September 26, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants